[Security Solution] Update wordings and breadcrumb for timelines page #90809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angorayc
added
v7.12.0
release_note:skip
angorayc
changed the title
angorayc
changed the title
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
| } | ||
| ); | ||
|
|
||
| export const SELECT_TIMELINE = i18n.translate( | ||
| 'xpack.securitySolution.timelines.components.importTimelineModal.selectTimelineDescription', | ||
| { | ||
| defaultMessage: 'Select a Security timeline (as exported from the Timeline view) to import', | ||
| defaultMessage: 'Select a security timeline or timeline template file to import', |
There was a problem hiding this comment.
(copy help needed)
Note: As we can import multiple timelines / templates in a file at a time, so I change the wording to Select a security timeline or timeline template file to import instead
The following text incorporates the multiple selection feature noted above:
Select one or more timeline or timeline template files to import
The word security is omitted in the suggestion above, which leaves open the possibility to import timelines or templates in an non-security context in the future.
There was a problem hiding this comment.
Yup, omitted security sounds good, but at the moment we still only support importing a single ndjson file at a time. (However the ndjson file might contain more than one timeline or timeline template's json object in it.)
So I think just removing the security would be fine.
There was a problem hiding this comment.
Thanks for the clarification re: multiple selection vs multiple timelines in a single file. In that case, please consider the following suggestion:
Select a timeline or timeline template file to import
andrew-goldstein
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
Thanks for these changes @angorayc!
I made one suggestion per the request in the PR for copy feedback. Everything else looks good, and is tested locally.
LGTM 🙏
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Endpoint Functional Tests.x-pack/test/security_solution_endpoint/apps/endpoint/policy_details·ts.endpoint When on the Endpoint Policy Details Page and the save button is clicked should have cleared the advanced section when the user deletes the valueStandard OutStack TraceMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 25, 2021
…tiple-searchable-snapshot-actions * 'master' of github.com:elastic/kibana: [Rollup] Fix use of undefined value in JS import (elastic#92791) [ILM] Fix replicas not showing (elastic#92782) [Event Log] Extended README.md with the documentation for a REST API and Start plugin contract. (elastic#92562) [XY] Enables page reload toast for the legacyChartsLibrary setting (elastic#92811) [Security Solution][Case] Improve hooks (elastic#89580) [Security Solution] Update wordings and breadcrumb for timelines page (elastic#90809) [Security Solution] Replace EUI theme with mocks in jest suites (elastic#92462) docs: ✏️ use correct heading level (elastic#92806) [ILM ] Fix logic for showing/hiding recommended allocation on Cloud (elastic#90592) [Security Solution][Detections] Pull gap detection logic out in preparation for sharing between rule types (elastic#91966) [core.savedObjects] Remove _shard_doc tiebreaker since ES now adds it automatically. (elastic#92295) docs: ✏️ fix links in embeddable plugin readme (elastic#92778) # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/searchable_snapshot_field/searchable_snapshot_field.tsx
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Feb 25, 2021
…elastic#90809) * update wordings * unit tests * remove tabName from breadcrumbs * update wordings * change default status of timelines to null * fix loading message * update select timeline wording Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Feb 25, 2021
…elastic#90809) * update wordings * unit tests * remove tabName from breadcrumbs * update wordings * change default status of timelines to null * fix loading message * update select timeline wording Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
angorayc
added a commit
that referenced
this pull request
Feb 25, 2021
…#90809) (#92865) * update wordings * unit tests * remove tabName from breadcrumbs * update wordings * change default status of timelines to null * fix loading message * update select timeline wording Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
angorayc
added a commit
that referenced
this pull request
Feb 26, 2021
…#90809) (#92866) * update wordings * unit tests * remove tabName from breadcrumbs * update wordings * change default status of timelines to null * fix loading message * update select timeline wording Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to update the wording on timelines page, to differentiate between
timelineandtimeline template.Items to check:
Update wordings:
#87469
Note: As we can import multiple timelines / templates in a file at a time, so I change the wording to Select a security timeline or timeline template file to import instead
[Security Solution] "0 timeline match the search criteria" message is displaying while data is being uploaded under timeline tab. #86884
Update breadcrumbs:
[Security Solution] Create Timeline page is displaying under Templates tab on clicking Discard Timeline Template button #87458
Updated UX:
Checklist
Delete any items that are not applicable to this PR.