Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ILM] Fix replicas not showing #92782

Merged
merged 3 commits into from
Feb 25, 2021
Merged

[ILM] Fix replicas not showing #92782

merged 3 commits into from
Feb 25, 2021

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Feb 25, 2021 •
edited
Loading

Summary

Fix #92590

Description of form behaviour after these changes:

  • Fix replicas field not showing in cold phase when searchable snapshots enabled in cold phase
  • Additionally, the searchable snapshot field in the cold phase should not be disabled if rollover is disabled. Searchable snapshots is only disabled in hot phase if rollover is disabled. Searchable snapshot is usable in cold phase regardless of rollover in hot phase. This was pointed out in conversation with @andreidan when we re-reviewed fields that show/don't show based on rollover and searchable snapshots in the ILM UI.

Release note

Fixed a bug in the ILM policy UI that would prevent users from configuring replicas in the cold phase when searchable snapshots is enabled. Additionally, fixed a bug that disabled the searchable snapshot action in the cold phase when rollover is disabled.

Checklist

@jloleysens jloleysens added release_note:fix Feature:ILM v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.12.0 v7.13.0 v7.11.2 labels Feb 25, 2021
@jloleysens jloleysens requested a review from a team as a code owner February 25, 2021 11:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

andreidan
andreidan approved these changes Feb 25, 2021
View reviewed changes
Copy link

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description LGTM, thanks for working on this JL

yuliacech
yuliacech approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jloleysens, thanks a lot for fixing this! code changes LGTM and tested locally to make sure all works 👍

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexLifecycleManagement 240.1KB 239.2KB -999.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit bc347d8 into master Feb 25, 2021
@jloleysens jloleysens deleted the ilm/fix-which-fields-are-showing-with-ss branch February 25, 2021 17:05
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 25, 2021
@jloleysens @kibanamachine
[ILM] Fix replicas not showing (elastic#92782)
65ec1f3 
* remove logic that disables SS action in cold if no rollover and always show replicas field

* update test coverage to be consistent with new form behaviour and expand hot phase without rollover test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@jloleysens jloleysens mentioned this pull request Feb 25, 2021
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 25, 2021
@jloleysens @kibanamachine
[ILM] Fix replicas not showing (elastic#92782)
616f6ee 
* remove logic that disables SS action in cold if no rollover and always show replicas field

* update test coverage to be consistent with new form behaviour and expand hot phase without rollover test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@jloleysens jloleysens mentioned this pull request Feb 25, 2021
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 25, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/allow-mul…
67568d9 
…tiple-searchable-snapshot-actions

* 'master' of github.com:elastic/kibana:
  [Rollup] Fix use of undefined value in JS import (elastic#92791)
  [ILM] Fix replicas not showing  (elastic#92782)
  [Event Log] Extended README.md with the documentation for a REST API and Start plugin contract. (elastic#92562)
  [XY] Enables page reload toast for the legacyChartsLibrary setting (elastic#92811)
  [Security Solution][Case] Improve hooks (elastic#89580)
  [Security Solution] Update wordings and breadcrumb for timelines page (elastic#90809)
  [Security Solution] Replace EUI theme with mocks in jest suites (elastic#92462)
  docs: ✏️ use correct heading level (elastic#92806)
  [ILM ] Fix logic for showing/hiding recommended allocation on Cloud (elastic#90592)
  [Security Solution][Detections] Pull gap detection logic out in preparation for sharing between rule types (elastic#91966)
  [core.savedObjects] Remove _shard_doc tiebreaker since ES now adds it automatically. (elastic#92295)
  docs: ✏️ fix links in embeddable plugin readme (elastic#92778)

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/searchable_snapshot_field/searchable_snapshot_field.tsx
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 25, 2021
@jloleysens
[ILM] Fix replicas not showing (elastic#92782)
bbf6b2a 
* remove logic that disables SS action in cold if no rollover and always show replicas field

* update test coverage to be consistent with new form behaviour and expand hot phase without rollover test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/cold_phase/cold_phase.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/warm_phase/warm_phase.tsx
@jloleysens jloleysens mentioned this pull request Feb 25, 2021
Merged
jloleysens added a commit that referenced this pull request Feb 25, 2021
@jloleysens @kibanamachine
[ILM] Fix replicas not showing (#92782) (#92854)
a5d77e5 
* remove logic that disables SS action in cold if no rollover and always show replicas field

* update test coverage to be consistent with new form behaviour and expand hot phase without rollover test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens added a commit that referenced this pull request Feb 25, 2021
@jloleysens @kibanamachine
[ILM] Fix replicas not showing (#92782) (#92856)
a4c59a6 
* remove logic that disables SS action in cold if no rollover and always show replicas field

* update test coverage to be consistent with new form behaviour and expand hot phase without rollover test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens added a commit that referenced this pull request Mar 1, 2021
@jloleysens @kibanamachine
[7.11] [ILM] Fix replicas not showing (#92782) (#92871)
2edcde4 
* [ILM] Fix replicas not showing  (#92782)

* remove logic that disables SS action in cold if no rollover and always show replicas field

* update test coverage to be consistent with new form behaviour and expand hot phase without rollover test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/cold_phase/cold_phase.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/warm_phase/warm_phase.tsx

* added missing helpers

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuliacech yuliacech yuliacech approved these changes

@andreidan andreidan andreidan approved these changes

Assignees
No one assigned
Labels
Feature:ILM release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.11.2 v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ILM: searchable snapshot action hides the replicas action configuration
5 participants
@jloleysens @elasticmachine @kibanamachine @andreidan @yuliacech