Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps][File upload] Remove usage of max file size advanced setting 1GB limit in geo file upload #93261

Closed
thomasneirynck opened this issue Mar 2, 2021 · 2 comments · Fixed by #127639
Closed

[Maps][File upload] Remove usage of max file size advanced setting 1GB limit in geo file upload #93261

thomasneirynck opened this issue Mar 2, 2021 · 2 comments · Fixed by #127639
Assignees
@maksimkovalev
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result Feature:File Upload v8.2.0

Comments

@thomasneirynck
Copy link
Contributor

Discussed first here: #92620 (review)

The maxFileSize advanced-setting seems arbitrary, especially in the context of maps, since:
- preview only loads first 10k features
- ingest is streamed, so the file is not held in memory

Was suggested that this setting makes more sense as a sys-admin level safety break in kibana.yml, rather than a UX-level advanced setting

Since this is already a setting, as a first step we could just remove the 1GB limit

@nreese @jgowdyelastic @peteharverson @rudolf
@thomasneirynck thomasneirynck added discuss [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:File Upload labels Mar 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese changed the title [Maps][File upload] Remove max file size advanced setting 1GB limit [Maps][File upload] Remove usage of max file size advanced setting 1GB limit in geo file upload Feb 1, 2022
@nreese
Copy link
Contributor

nreese commented Feb 1, 2022

fileUpload:maxFileSize advanced setting is used by CSV file upload and geo file upload. Lets de-couple removal of fileUpload:maxFileSize advanced setting and removing usage of fileUpload:maxFileSize so geo file upload can be unbounded.

The scope of this issue should be limited to only removing maps usage of fileUpload:maxFileSize and not the removal fileUpload:maxFileSize advanced setting.

@nreese nreese removed the discuss label Feb 16, 2022
@nreese nreese added enhancement New value added to drive a business result v8.2.0 labels Feb 16, 2022
maksimkovalev added a commit to maksimkovalev/kibana that referenced this issue Mar 14, 2022
@maksimkovalev
elastic#93261 - Usage of maxFileSize in geo upload form is removed
4081032
@maksimkovalev maksimkovalev mentioned this issue Mar 15, 2022
Merged
nreese pushed a commit that referenced this issue Mar 16, 2022
@maksimkovalev @kibanamachine
[Maps][File upload] Remove usage of max file size advanced setting 1G…
0cd251e 
…B limit in geo file upload (#127639)

* #93261 - Usage of maxFileSize in geo upload form is removed

* 93261 - refactoring

* 93261 - fixed translation checks

* 93261 - documentation updates

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
maksimkovalev added a commit to maksimkovalev/kibana that referenced this issue Mar 18, 2022
@maksimkovalev @kibanamachine
[Maps][File upload] Remove usage of max file size advanced setting 1G…
c6b6fc1 
…B limit in geo file upload (elastic#127639)

* elastic#93261 - Usage of maxFileSize in geo upload form is removed

* 93261 - refactoring

* 93261 - fixed translation checks

* 93261 - documentation updates

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maksimkovalev maksimkovalev

Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result Feature:File Upload v8.2.0
Projects
None yet
Milestone
No milestone
4 participants
@nreese @thomasneirynck @maksimkovalev @elasticmachine