-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Add span icons for AWS and Azure services #96284
Comments
Pinging @elastic/apm-ui (Team:apm) |
@AlexanderWert Wondering if we want to have more detail in the icons than the AWS and Azure icons themselves? For the person implementing this, EUI already has these two as third party icons but they'll need to converted to custom SVGs (one for each light and dark theme). |
@formgeist Good question. I could imagine that having service-specific icons could provide additional value in identifying the services: But I don't have a strong opinion on this. @alex-fedotyev , @cyrille-leclerc what do you think? |
Thanks for looking at this. |
@AlexanderWert Do you know if we're going to display AWS DynamoDB as the |
@formgeist Ss of the current SPEC, the fields for DynamoDb will be:
Thus, yes, if the display name is using the subtype or span.destination.service.name, then it will show the explicit name |
@AlexanderWert Excellent! Thanks for confirming 👍 |
@AlexanderWert Is this issue just about DynamoDB? (only seeing type and subtype for that here #96284 (comment)) |
@sqren The description refers to elastic/apm#410 and elastic/apm#408 for both AWS and Azure subtypes that we'll need to show either icons for. |
@formgeist I did look at those but it was still not clear to me what the |
Generally, what I'd like is for this info to be in the issue description (if possible). |
@sqren , see table above (in the description). Is that what you were asking for? |
@AlexanderWert That's perfect, thanks! |
@AlexanderWert fyi, these are the supported types/subtypes after my changes in #101901: |
APM agents are introducing new instrumentations for AWS (elastic/apm#408) and Azure (elastic/apm#410) services. To represent these instrumentations with proper icons in trace views and the service map, we need to add corresponding span icons to the UI.
Type, Subtype:
type
subtype
The text was updated successfully, but these errors were encountered: