Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix migration 7.12 to 7.13 migrate settings #100054

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented May 13, 2021

Summary

Resolve #100050

During the migration for fleet server we create the .fleet-policies before creating the fleet settings with fleet server hosts. Because of that in cloud this resulted with a .fleet-policies with the fleet.* part.

That PR fix it.

How to test

with a cloud config in kibana.dev.yml

xpack.cloud.enabled: true
xpack.cloud.id: 'staging:dXMtZWFzdC0xLmF3cy5mb3VuZC5pbyRjZWM2ZjI2MWE3NGJmMjRjZTMzYmI4ODExYjg0Mjk0ZiRjNmMyY2E2ZDA0MjI0OWFmMGNjN2Q3YTllOTYyNTc0Mw=='
xpack.cloud.deployment_url: '/test/deployment-1'
xpack.cloud.base_url: 'http://test.fr'
  • start kibana 7.12 and es 7.12 (you can use that command to persist data for the migration yarn es snapshot --license trial --password changeme -E xpack.security.authc.api_key.enabled=true -E path.data=/tmp/es-data)
  • setup agents in kibana 7.12
  • Start kibana and ES on that branch
  • Visit the fleet plugin
  • Check policies contains the fleet.* part. (GET .fleet-policies/_search in the devtools)

@nchaulet nchaulet self-assigned this May 13, 2021
@nchaulet nchaulet added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.13.0 v7.14.0 v8.0.0 labels May 13, 2021
@nchaulet nchaulet marked this pull request as ready for review May 13, 2021 16:45
@nchaulet nchaulet requested a review from a team as a code owner May 13, 2021 16:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet requested a review from jfsiii May 13, 2021 18:13
@nchaulet nchaulet added the bug Fixes for quality problems that affect the customer experience label May 13, 2021
@nchaulet nchaulet requested a review from jen-huang May 14, 2021 01:24
@nchaulet nchaulet enabled auto-merge (squash) May 14, 2021 12:41
@nchaulet nchaulet requested a review from kpollich May 17, 2021 12:19
@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
stackAlerts 101 95 -6
total -295

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.13
7.x

The backport PRs will be merged automatically after passing CI.

@nchaulet nchaulet deleted the fix-cloud-migration-policy-fleet-host-settings branch May 17, 2021 14:26
kibanamachine added a commit that referenced this pull request May 17, 2021
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
kibanamachine added a commit that referenced this pull request May 17, 2021
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
yctercero pushed a commit to yctercero/kibana that referenced this pull request May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.13.0 v7.14.0 v8.0.0
Projects
None yet
4 participants