Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes circular deps for lists in tooling and bumps down byte limit for lists #100082

Merged
merged 2 commits into from
May 13, 2021
Merged

Removes circular deps for lists in tooling and bumps down byte limit for lists #100082

merged 2 commits into from
May 13, 2021

Conversation

FrankHassanabad
Copy link
Contributor

Summary

  • Removes circular deps exception for lists
  • Bumps down byte limit for lists now that we have decreased the page bytes to be under 200kb

@FrankHassanabad FrankHassanabad requested a review from a team as a code owner May 13, 2021 20:39
@FrankHassanabad FrankHassanabad self-assigned this May 13, 2021
@FrankHassanabad FrankHassanabad added v8.0.0 v7.14.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed labels May 13, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 4 2 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 5 3 -2
licensing 18 15 -3
monitoring 109 56 -53
total -73

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @FrankHassanabad

@FrankHassanabad FrankHassanabad merged commit 3da9a78 into elastic:master May 13, 2021
@FrankHassanabad FrankHassanabad deleted the remove-lists-from-circles branch May 13, 2021 22:37
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 13, 2021
@FrankHassanabad @kibanamachine
Removes circular deps for lists in tooling and bumps down byte limit …
59a9289 
…for lists (elastic#100082)

## Summary

* Removes circular deps exception for lists
* Bumps down byte limit for lists now that we have decreased the page bytes to be under 200kb
@kibanamachine kibanamachine mentioned this pull request May 13, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 14, 2021
@kibanamachine @FrankHassanabad
Removes circular deps for lists in tooling and bumps down byte limit …
f09cb9c 
…for lists (#100082) (#100097)

## Summary

* Removes circular deps exception for lists
* Bumps down byte limit for lists now that we have decreased the page bytes to be under 200kb

Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
gmmorris added a commit to chrisronline/kibana that referenced this pull request May 14, 2021
@gmmorris
Merge branch 'master' into pr/97311
44babf8 
* master: (27 commits)
  Disable contextMenu when event is not event.kind=event (elastic#100027)
  Updates the monorepo-packages list (elastic#100096)
  Removes circular deps for lists in tooling and bumps down byte limit for lists (elastic#100082)
  [Security Solutions] Breaks down the io-ts packages to decrease plugin size (elastic#100058)
  fix-typo: Use of `than` instead of `then` (elastic#100030)
  [Fleet] Fix error when searching for keys whose names have spaces (elastic#100056)
  [Workplace Search] Fix bug when transitioning to personal dashboard (elastic#100061)
  [index pattern field editor] Update runtime field painless docs url (elastic#100014)
  [QA] Switch tests to use importExport - visualize (elastic#98063)
  [Canvas] Remove unused legacy autocomplete component (elastic#99215)
  Re-enable formerly flaky shareable test (elastic#98826)
  [Uptime] [Synthetics Integration] ensure that proxy url is not overwritten (elastic#99944)
  [Security Solutions][Lists] Trims down list plugin size by breaking out the exception builder into chunks by using react lazy loading (elastic#99989)
  [Uptime] Increase debounce and add immediate submit to `useQueryBar` (elastic#99675)
  chore(NA): moving @kbn/docs-utils into bazel (elastic#100051)
  [Enterprise Search] Fix SchemaFieldTypeSelect axe issues (elastic#100035)
  Remove outdated comment about schema validation not working (it does work now). (elastic#100055)
  Rename alert status OK to Recovered and fix some UX issues around disabling a rule while being in an error state (elastic#98135)
  [Fleet] Do not use async method in plugin setup|start (elastic#100033)
  Skip flaky functional test suite
  ...
yctercero pushed a commit to yctercero/kibana that referenced this pull request May 17, 2021
@FrankHassanabad @yctercero
Removes circular deps for lists in tooling and bumps down byte limit …
d466406 
…for lists (elastic#100082)

## Summary

* Removes circular deps exception for lists
* Bumps down byte limit for lists now that we have decreased the page bytes to be under 200kb
yctercero pushed a commit to yctercero/kibana that referenced this pull request May 25, 2021
@FrankHassanabad @yctercero
Removes circular deps for lists in tooling and bumps down byte limit …
ad4fcd2 
…for lists (elastic#100082)

## Summary

* Removes circular deps exception for lists
* Bumps down byte limit for lists now that we have decreased the page bytes to be under 200kb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

Assignees

@FrankHassanabad FrankHassanabad

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrankHassanabad @kibanamachine @jbudz