Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [Workplace Search] Fix bug when transitioning to personal dashboard (#100061) #100090

Merged
merged 1 commit into from
May 13, 2021
Merged

[7.x] [Workplace Search] Fix bug when transitioning to personal dashboard (#100061) #100090

merged 1 commit into from
May 13, 2021

Commits on May 13, 2021

  1. [Workplace Search] Fix bug when transitioning to personal dashboard (e… 

    …lastic#100061)

The unmount callback should have never been in the useEffect keyed off of the pathname. Another issue appeared earlier and I tried to fix it with the now removed conditional, but it should have been removed into it’s own useEffect that only runs when the component is unmounted, not on every route change.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    @scottybollinger @kibanamachine
    scottybollinger and kibanamachine committed May 13, 2021
    Configuration menu
    Copy the full SHA
    97d05c1 View commit details
    Browse the repository at this point in the history