Fix status page functional test #100146
Merged
Fix status page functional test #100146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlemeshko
commented
May 14, 2021
Comment on lines
-32
to
+19
| return await retry.try(async () => { | ||
| log.debug(`expectStatusPage()`); | ||
| await find.byCssSelector('[data-test-subj="statusPageRoot"]', 20000); | ||
| const url = await browser.getCurrentUrl(); | ||
| expect(url).to.contain(`/status`); | ||
| }); | ||
| await find.byCssSelector('[data-test-subj="statusPageRoot"]', 20000); |
There was a problem hiding this comment.
navigateToApp validates the url correctness, so we just need to check UI element to be present. Find service will search for element for 20 sec, should be good enough.
dmlemeshko
commented
May 14, 2021
| const find = getService('find'); | ||
| const deployment = getService('deployment'); |
There was a problem hiding this comment.
This test won't work on Cloud: user can't navigate to /status page after log out. So I think we can safely remove deployment service usage.
dmlemeshko
commented
May 14, 2021
| @@ -203,7 +203,6 @@ | |||
| /packages/kbn-legacy-logging/ @elastic/kibana-core | |||
| /packages/kbn-crypto/ @elastic/kibana-core | |||
| /packages/kbn-http-tools/ @elastic/kibana-core | |||
| /src/plugins/status_page/ @elastic/kibana-core | |||
There was a problem hiding this comment.
path no longer exists
dmlemeshko
added
the
release_note:skip
💚 Build SucceededMetrics [docs]Unknown metric groupsReferences to deprecated APIs
To update your PR or re-run it, just comment with: |
wayneseymour
approved these changes
May 14, 2021
dmlemeshko
added
the
auto-backport
💔 Backport failed
To backport manually run: |
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
May 14, 2021
# Conflicts: # .github/CODEOWNERS
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
May 14, 2021
# Conflicts: # .github/CODEOWNERS
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
May 14, 2021
# Conflicts: # .github/CODEOWNERS
dmlemeshko
added a commit
that referenced
this pull request
May 15, 2021
dmlemeshko
added a commit
that referenced
this pull request
May 15, 2021
dmlemeshko
added a commit
that referenced
this pull request
May 15, 2021
yctercero
pushed a commit
to yctercero/kibana
that referenced
this pull request
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-enabling status page test by changing navigation method. If it will fail, we will get a clear message but not timeout error as right now
closes #50448
Flaky test runner
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1548/ (30x - passed, 1 non-related failure in Spaces app)