Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Osquery] Fix issue with plugin initialization #100208

Merged
merged 9 commits into from
Jul 6, 2021
Merged

[Osquery] Fix issue with plugin initialization #100208

merged 9 commits into from
Jul 6, 2021

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented May 17, 2021 •
edited
Loading

Summary

Fixes #100285

@patrykkopycinski patrykkopycinski added bug Fixes for quality problems that affect the customer experience v8.0.0 v7.14.0 v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels May 17, 2021
@patrykkopycinski patrykkopycinski self-assigned this May 17, 2021
@patrykkopycinski patrykkopycinski added release_note:feature Makes this part of the condensed release notes Feature:Osquery Security Solution Osquery feature Team:Asset Management Security Asset Management Team labels May 17, 2021
@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski marked this pull request as ready for review May 17, 2021 13:41
@patrykkopycinski patrykkopycinski requested a review from a team as a code owner May 17, 2021 13:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-asset-management (Team:Asset Management)

lykkin
lykkin approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@lykkin lykkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔌 📦

@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into fix/osquery-p…
0c4f0fa 
…lugin-setupp

# Conflicts:
#	x-pack/plugins/osquery/public/plugin.ts
@patrykkopycinski
add status route
7ea3d36
@patrykkopycinski patrykkopycinski requested review from a team as code owners July 4, 2021 21:37
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jul 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@patrykkopycinski patrykkopycinski changed the title [Osquery] Fix cirtical issue with plugin initialization [Osquery] Fix issue with plugin initialization Jul 4, 2021
nchaulet
nchaulet reviewed Jul 5, 2021
View reviewed changes
x-pack/plugins/osquery/server/routes/status/create_status_route.ts
Comment on lines +20 to +22
const isSuperUser = osqueryContext.security.authc
.getCurrentUser(request)
?.roles.includes('superuser');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if we should expose a method in Fleet to do that something like isAuthorized(request). I think in the future we want to allow non superuser with enough permissions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would be helpful @nchaulet. We are also working on allowing to use Osquery for non superuser

@patrykkopycinski patrykkopycinski added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:feature Makes this part of the condensed release notes labels Jul 5, 2021
@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski enabled auto-merge (squash) July 6, 2021 19:54
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1038 1037 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
osquery 880.4KB 880.4KB +2.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
osquery 13.6KB 13.4KB -197.0B
Unknown metric groups

API count

id before after diff
fleet 1133 1132 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

@patrykkopycinski patrykkopycinski merged commit b17ad5d into elastic:master Jul 6, 2021
@kibanamachine kibanamachine mentioned this pull request Jul 6, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 6, 2021
@patrykkopycinski @kibanamachine
[Osquery] Fix issue with plugin initialization (elastic#100208)
b1eeac0
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 6, 2021
@patrykkopycinski @kibanamachine
[Osquery] Fix issue with plugin initialization (elastic#100208)
7d0a5e1
@kibanamachine kibanamachine mentioned this pull request Jul 6, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 7, 2021
@kibanamachine @patrykkopycinski
[Osquery] Fix issue with plugin initialization (#100208) (#104562)
04dbcec 
Co-authored-by: Patryk Kopyciński <patryk.kopycinski@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 7, 2021
@kibanamachine @patrykkopycinski
[Osquery] Fix issue with plugin initialization (#100208) (#104563)
3cdd337 
Co-authored-by: Patryk Kopyciński <patryk.kopycinski@elastic.co>
@patrykkopycinski patrykkopycinski deleted the fix/osquery-plugin-setupp branch July 7, 2021 09:51
darnautov pushed a commit to darnautov/kibana that referenced this pull request Jul 7, 2021
@patrykkopycinski @darnautov
[Osquery] Fix issue with plugin initialization (elastic#100208)
2f66bf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-elastic james-elastic james-elastic approved these changes

@lykkin lykkin lykkin approved these changes

@nchaulet nchaulet nchaulet approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Osquery Security Solution Osquery feature release_note:skip Skip the PR/issue when compiling release notes Team:Asset Management Security Asset Management Team Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kibana 403 error shows in browser dev tools Console for non-superusers
6 participants
@patrykkopycinski @elasticmachine @kibanamachine @nchaulet @lykkin @james-elastic