Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Add clear button to search input bars #100476

Merged
merged 1 commit into from
May 24, 2021
Merged

[Fleet] Add clear button to search input bars #100476

merged 1 commit into from
May 24, 2021

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented May 24, 2021

Summary

Closes #98734

Adds the isClearable flag to search bars throughout the Fleet app.

Screen Shot 2021-05-24 at 11 52 58 AM

@Zacqary Zacqary added release_note:fix v8.0.0 Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 labels May 24, 2021
@Zacqary Zacqary self-assigned this May 24, 2021
@Zacqary Zacqary requested a review from a team as a code owner May 24, 2021 16:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Feature:Fleet)

jen-huang
jen-huang approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and quick, thanks!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 731.3KB 731.3KB +15.0B
Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 386 342 -44
stackAlerts 101 95 -6
total -342

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Zacqary

@Zacqary Zacqary added the auto-backport Deprecated - use backport:version if exact versions are needed label May 24, 2021
@Zacqary Zacqary merged commit 676d40e into elastic:master May 24, 2021
@Zacqary Zacqary deleted the 98734-clearable-searchbar branch May 24, 2021 22:30
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 24, 2021
@Zacqary @kibanamachine
[Fleet] Add clear button to search input bars (elastic#100476)
cbc52e1
@kibanamachine kibanamachine mentioned this pull request May 24, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 25, 2021
@kibanamachine @Zacqary
[Fleet] Add clear button to search input bars (#100476) (#100517)
e8af136 
Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>
ecezalp pushed a commit to ecezalp/kibana that referenced this pull request May 26, 2021
@Zacqary @ecezalp
[Fleet] Add clear button to search input bars (elastic#100476)
f260f19
ecezalp pushed a commit to ecezalp/kibana that referenced this pull request May 26, 2021
@Zacqary @ecezalp
[Fleet] Add clear button to search input bars (elastic#100476)
98d9bbd
@mdelapenya mdelapenya mentioned this pull request May 28, 2021
Merged
@jen-huang jen-huang mentioned this pull request Jun 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jen-huang jen-huang jen-huang approved these changes

Assignees

@Zacqary Zacqary

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Fleet Fleet team's agent central management project release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] Agents list - Table search/filter doesn't show a clear option
4 participants
@Zacqary @elasticmachine @kibanamachine @jen-huang