Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Fix incomplete agent count message on policy tab #100497

Merged
merged 1 commit into from
May 24, 2021
Merged

[Fleet] Fix incomplete agent count message on policy tab #100497

merged 1 commit into from
May 24, 2021

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented May 24, 2021

Summary

Closes #91824

Screen Shot 2021-05-24 at 3 10 48 PM

Screen Shot 2021-05-24 at 3 10 43 PM

Restores the word agents to the Used by column on the policy page.

Checklist

@Zacqary Zacqary added release_note:fix v8.0.0 Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 labels May 24, 2021
@Zacqary Zacqary self-assigned this May 24, 2021
@Zacqary Zacqary requested a review from a team as a code owner May 24, 2021 20:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 731.3KB 731.6KB +338.0B
Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 386 342 -44
stackAlerts 101 95 -6
total -342

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Zacqary

@Zacqary Zacqary added the auto-backport Deprecated - use backport:version if exact versions are needed label May 24, 2021
@Zacqary Zacqary merged commit f95bbb3 into elastic:master May 24, 2021
@kibanamachine kibanamachine mentioned this pull request May 24, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 24, 2021
@Zacqary @kibanamachine
[Fleet] Fix incomplete agent count message on policy tab (elastic#100497
7689d2f 
)
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 25, 2021
@kibanamachine @Zacqary
[Fleet] Fix incomplete agent count message on policy tab (#100497) (#…
c7f8276 
…100515)

Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>
ecezalp pushed a commit to ecezalp/kibana that referenced this pull request May 26, 2021
@Zacqary @ecezalp
[Fleet] Fix incomplete agent count message on policy tab (elastic#100497
179291d 
)
ecezalp pushed a commit to ecezalp/kibana that referenced this pull request May 26, 2021
@Zacqary @ecezalp
[Fleet] Fix incomplete agent count message on policy tab (elastic#100497
4f13523 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

Assignees

@Zacqary Zacqary

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] The policy tab shows incomplete message for the count of agents that may cause ambiguity to the user
4 participants
@Zacqary @elasticmachine @kibanamachine @kpollich