Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Unskip Discover large field number test #100692

Merged

Conversation

kertal
Copy link
Member

@kertal kertal commented May 26, 2021

Summary

Unskips Discover large field number test, by splitting the fixtures with a doc containing 10.000 fields to 3 docs. So there's no more occasional 'circuit_breaking_exception' of Elasticsearch. Furthermore improves and speeds up the test by providing an index pattern in the fixtures, so it's no longer necessary to "manually" create the index pattern in index management.

Fixes #96113

Flaky test runner https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1675/

Checklist

@kertal kertal added the Feature:Discover Discover Application label May 26, 2021
@kertal kertal self-assigned this May 26, 2021
@kertal kertal added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label May 27, 2021
@kertal
Copy link
Member Author

kertal commented May 31, 2021

@elasticmachine merge upstream

@kertal kertal added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.14.0 labels Jun 4, 2021
@kertal kertal marked this pull request as ready for review June 4, 2021 10:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal
Copy link
Member Author

kertal commented Jun 4, 2021

@elasticmachine merge upstream

@kertal kertal requested review from mistic and majagrubic June 4, 2021 10:11
@LeeDr
Copy link

LeeDr commented Jun 4, 2021

This test had been passing for a long time. What caused it to start failing? Users are very frequently asking about indices with very large field counts. This seems like a regression if this test now fails.

@LeeDr
Copy link

LeeDr commented Jun 4, 2021

hmm, I was actually thinking about test kibana\test\functional\apps\management_test_huge_fields.js but that one uses the same data and is also skipped. For the same reason I think? Still seems like a regression.

@kertal
Copy link
Member Author

kertal commented Jun 4, 2021

@LeeDr it seems to be an issue with Elasticsearch memory usage:

[00:32:18] │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1622098084918717614] [testhuge/w1UtHxqrQ62_lsWyBr4_jA] update_mapping [_doc]
[00:32:19] │ info [o.e.i.b.HierarchyCircuitBreakerService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1622098084918717614] attempting to trigger G1GC due to high heap usage [1047026976]
[00:32:19] │ info [o.e.i.b.HierarchyCircuitBreakerService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1622098084918717614] GC did not bring memory usage down, before [1047026976], after [1055780592], allocations [4], duration [12]

@kertal
Copy link
Member Author

kertal commented Jun 21, 2021

@elasticmachine merge upstream

@kertal kertal requested a review from LeeDr June 22, 2021 16:46
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

Copy link
Contributor

@dimaanj dimaanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@kertal kertal added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 23, 2021
@kertal kertal merged commit 12aa46f into elastic:master Jun 23, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 23, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 23, 2021
Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
5 participants