-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Unskip Discover large field number test #100692
[Discover] Unskip Discover large field number test #100692
Conversation
@elasticmachine merge upstream |
Pinging @elastic/kibana-app (Team:KibanaApp) |
@elasticmachine merge upstream |
This test had been passing for a long time. What caused it to start failing? Users are very frequently asking about indices with very large field counts. This seems like a regression if this test now fails. |
hmm, I was actually thinking about test kibana\test\functional\apps\management_test_huge_fields.js but that one uses the same data and is also skipped. For the same reason I think? Still seems like a regression. |
@LeeDr it seems to be an issue with Elasticsearch memory usage: [00:32:18] │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1622098084918717614] [testhuge/w1UtHxqrQ62_lsWyBr4_jA] update_mapping [_doc] |
…hub.com:kertal/kibana into kertal-pr-2021-05-26-unskip-large-field-nr-test
@elasticmachine merge upstream |
…-26-unskip-large-field-nr-test
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @kertal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM!
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Summary
Unskips Discover large field number test, by splitting the fixtures with a doc containing 10.000 fields to 3 docs. So there's no more occasional 'circuit_breaking_exception' of Elasticsearch. Furthermore improves and speeds up the test by providing an index pattern in the fixtures, so it's no longer necessary to "manually" create the index pattern in index management.
Fixes #96113
Flaky test runner https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1675/
Checklist