Saved object export: apply export hooks to referenced / nested objects #100769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
release_note:skip
…ive-export-transform
pgayvallet
commented
May 31, 2021
Comment on lines
+133
to
+134
| // sort with the provided sort function then with the default export sorting | ||
| const exportedObjects = sortObjects(collectedObjects.sort(sortFunction)); |
There was a problem hiding this comment.
This behavior is unchanged, the double sorting was just performed in two different steps
|
Pinging @elastic/kibana-core (Team:Core) |
Bamieh
reviewed
Jun 3, 2021
mshustov
approved these changes
Jun 3, 2021
src/core/server/saved_objects/export/collect_exported_objects.ts
Outdated
Show resolved
Hide resolved
src/core/server/saved_objects/export/collect_exported_objects.ts
Outdated
Show resolved
Hide resolved
…ive-export-transform
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Jun 4, 2021
elastic#100769) * execute export transform for nested references * fix sort * fix duplicate references * add FTR test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #100043
onExporttype hooks were only invoked for root level objects during the export process. Objects included by reference were not invoking the export hooks, causing inconsistency on the exports when objects were only included implicitly by reference.This PR fixes this, by invoking a type's
onExporthook for objects included by reference inside the export.Note: objects added to the export via an export hook are still not re-invoking their type's
onExport. This is outside of the scope of this PRChecklist