Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability] Expose options to customize sidebar route matching #100886

Merged
merged 3 commits into from
Jun 1, 2021
Merged

[Observability] Expose options to customize sidebar route matching #100886

merged 3 commits into from
Jun 1, 2021

Conversation

weltenwort
Copy link
Member

📝 Summary

This enhances the shared Observability navigation such that the registering plugin can control whether the url for activating a menu entry is matched strictly or not.

✨ New features

For each NavigationEntry the following new properties are available:

Property Default Description
matchFullPath?: boolean false Controls whether to only match when the full path matches or also when only the prefix matches.
ignoreTrailingSlash?: boolean true Controls whether to ignore trailing slashes.

@weltenwort weltenwort added v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes Team:Observability Team label for Observability Team (for things that are handled across all of observability) v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels May 28, 2021
@weltenwort weltenwort added this to the Logs UI 7.14 milestone May 28, 2021
@weltenwort weltenwort self-assigned this May 28, 2021
@shahzad31 shahzad31 mentioned this pull request May 28, 2021
Merged
7 tasks
@weltenwort weltenwort marked this pull request as ready for review May 28, 2021 15:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort weltenwort requested a review from shahzad31 May 28, 2021 21:07
shahzad31
shahzad31 approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for the purpose !!

@weltenwort
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 461.1KB 461.2KB +62.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @weltenwort

@weltenwort weltenwort merged commit f7698bd into elastic:master Jun 1, 2021
@weltenwort weltenwort deleted the obs-shared-nav-add-path-option branch June 1, 2021 09:21
@kibanamachine kibanamachine mentioned this pull request Jun 1, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 1, 2021
@weltenwort @kibanamachine
[Observability] Expose options to customize sidebar route matching (e…
50c6058 
…lastic#100886)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 1, 2021
@kibanamachine @weltenwort
[Observability] Expose options to customize sidebar route matching (#…
4e5bc21 
…100886) (#101036)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees

@weltenwort weltenwort

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Team:Observability Team label for Observability Team (for things that are handled across all of observability) v7.14.0 v8.0.0
Projects
None yet
Milestone
Logs UI 7.14
Development

Successfully merging this pull request may close these issues.
4 participants
@weltenwort @elasticmachine @kibanamachine @shahzad31