-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deprecations service] add deprecationType
and use it in configs deprecations
#100983
Conversation
Pinging @elastic/kibana-core (Team:Core) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks fine. A few NITs and comment on the tests
* Side Public License, v 1. | ||
*/ | ||
|
||
/* eslint-disable dot-notation */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a test suite #registerConfigDeprecationsInfo
which is a private method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method method = TargetClass.getDeclaredMethod(methodName, argClasses);
method.setAccessible(true);
method.invoke(targetObject, argObjects);
💚 Build SucceededMetrics [docs]Unknown metric groupsAPI count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Summary
Ada a new field
deprecationType
. The field is used to identify between different deprecation types. Example use case: in Upgrade Assistant, we may want to allow the user to sort by deprecation type or show each type in a separate tab.Current TS definition of the field:
The
deprecationType
values are predefined to reduce having similar definitions with different keywords across kibana deprecations. Allowing anystring
to be used as adeprecationType
would reduce the usefulness of this field.The new field is optional. UA might need to categorize deprecations with no
deprecationType
specified to anuncategorized
grouping.The field is optional to:
uncategorized
as a dedicated category but that would be almost identical to making the field optional.Changes
deprecationType
to deprecations service external contractDeprecationsDetails
.deprecationType: 'config'
for configs deprecations.Closes #96060