Fix UI breaks on providing long search keyword in 'Search Box' #101385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machadoum
added
bug
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
looks good as well! here's the design thumbs up 👍 thanks @machadoum |
|
@elasticmachine merge upstream |
angorayc
reviewed
Jun 7, 2021
| @@ -30,6 +31,11 @@ import * as i18n from './translations'; | |||
| import { OPEN_TIMELINE_CLASS_NAME } from './helpers'; | |||
| import { OpenTimelineProps, OpenTimelineResult, ActionTimelineToShow } from './types'; | |||
|
|
|||
| const SelectableQueryText = styled.span` | |||
There was a problem hiding this comment.
nit: SelectableQueryText doesn't seem to match the scenario here, please consider rename it. Aside from this, all looks good, verified on Chrome, Safari and Firefox. Thanks for fixing this @machadoum!
angorayc
approved these changes
Jun 7, 2021
Allowing words to wrap on whitespaces fixes the issue. I also added word-break for allowing long words to wrap.
machadoum
force-pushed
the
siem-timeline-issue-100321
branch
from
3864aad to
ce4ea2c
Compare
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @machadoum |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 7, 2021
* master: (90 commits) Fix UI breaks on providing long search keyword in 'Search Box' (elastic#101385) Adds css class to EuiDescriptionListDescription in order to break word on exception details card (elastic#101481) [Lens] Increase timings for drag and drop tests (elastic#101380) [Lens] Fix editor react error on configuration panel (elastic#101367) [Fleet] Move integrations to a separate app (elastic#99848) Fix incorrect message displayed on importing Timeline Templates (elastic#101288) [Cases] RBAC (elastic#95058) [APM] Visual improvements for new APM layout with left navigation (elastic#101360) [master] More precise alerts matching (elastic#99820) [Lens] Value in legend (elastic#101353) Revert "[Reporting] ILM policy for managing reporting indices (elastic#100130)" (elastic#101358) [Discover] Fix header row of data grid in Firefox (elastic#101374) Add link to advanced setting in Discover (elastic#101154) Url service locators (elastic#101045) [Timelion] Update the removal message to mention the exact version (elastic#100994) [Security Solution][Detection Engine] Test cases for alias failure test cases where we don't copy aliases correctly (elastic#101437) [Event Log] Adding `type_id` to saved object array in event log (elastic#100939) [Reporting] Add `location.url` info to console message logs (elastic#101427) [Security Solutions][Detection Engine] Fixes timestamp bugs within source indexes when the formats are not ISO8601 format (elastic#101349) Improve Task Manager instrumentation (elastic#99160) ...
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
machadoum
added a commit
to machadoum/kibana
that referenced
this pull request
Jun 10, 2021
…ic#101385) Allowing words to wrap on whitespaces fixes the issue. I also added word-break for allowing long words to wrap.
machadoum
added a commit
that referenced
this pull request
Jun 10, 2021
…) (#101880) Allowing words to wrap on whitespaces fixes the issue. I also added word-break for allowing long words to wrap.
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #100321
Summary
Allowing words to wrap on whitespaces fixes the issue.
I also added word-break for allowing long words to wrap.
Long query:
Medium size query
Query with one big word
Checklist