Update dependency @elastic/charts to v30 (master) #101409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
added
release_note:skip
botelastic
bot
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
nickofthyme
reviewed
Jun 4, 2021
| @@ -169,7 +169,7 @@ function getAxisDomain<S extends XScaleType | YScaleType>( | |||
|
|
|||
| const { min, max, defaultYExtents, boundsMargin } = scale; | |||
| const fit = defaultYExtents; | |||
| const padding = boundsMargin; | |||
| const padding = boundsMargin || undefined; | |||
There was a problem hiding this comment.
eui number input can be '' for some reason
nickofthyme
approved these changes
Jun 4, 2021
|
@elasticmachine merge upstream |
stratoula
approved these changes
Jun 7, 2021
|
@elasticmachine run elasticsearch-ci/docs |
shahzad31
reviewed
Jun 7, 2021
| @@ -113,7 +113,7 @@ export const DurationChartComponent = ({ | |||
| tickFormat={timeFormatter(getChartDateLabel(min, max))} | |||
| /> | |||
| <Axis | |||
| domain={{ min: 0 }} | |||
| domain={{ min: 0, fit: false }} | |||
There was a problem hiding this comment.
what impact this change will have?
There was a problem hiding this comment.
Short answer: Nothing. We deprecated yScaleToDataExtent in favor of this a while ago and finally fully removed the deprecated api. The function is exactly the same.
shahzad31
reviewed
Jun 7, 2021
| @@ -29,7 +29,6 @@ export const DurationLineSeriesList = ({ monitorType, lines }: Props) => ( | |||
| xAccessor={0} | |||
| xScaleType="time" | |||
| yAccessors={[1]} | |||
| yScaleToDataExtent={false} | |||
There was a problem hiding this comment.
what impact this change will have?
nickofthyme
reviewed
Jun 7, 2021
jgowdyelastic
approved these changes
Jun 7, 2021
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
@elasticmachine run elasticsearch-ci/docs |
|
Ping @elastic/logs-metrics-ui |
shahzad31
approved these changes
Jun 8, 2021
markov00
added a commit
to markov00/kibana
that referenced
this pull request
Jun 8, 2021
Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: nickofthyme <nick.ryan.partridge@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
markov00
added a commit
that referenced
this pull request
Jun 8, 2021
Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: nickofthyme <nick.ryan.partridge@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: nickofthyme <nick.ryan.partridge@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
29.2.0->30.0.0Release Notes
elastic/elastic-charts
v30.0.0Compare Source
Bug Fixes
Features
BREAKING CHANGES
textBorderofValueFillDefinitionis now optional or a number onlydomain.paddingnow only takes anumbervalue. If you are using a percent-based padding such as'10%'please setdomain.paddingto0.1anddomain.paddingUnittoDomainPaddingUnit.DomainRatio.yScaleToDataExtentis removed in favor ofdomain.fit. The functionality is thesame.
Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.