Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup outdated @elastic/elasticsearch client type errors #101741

Merged
merged 19 commits into from
Jun 21, 2021

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Jun 9, 2021

Summary

Follow up on #98266
Reduced the number of @ts-expect-error @elastic/elasticsearch from 111 to 65.

  • Fixes some TS errors
  • Updates @ts-expect-error @elastic/elasticsearch descriptions. You can find the full list of known problems here. These problems should be fixed in the following versions of the @elastic/elasticsearch library.
  • Removes @elastic/elasticsearch from @ts-expect-error when owners need to take actions to clean up the code (in separate PRs)

@mshustov mshustov added chore release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 9, 2021
@mshustov mshustov requested review from a team as code owners June 9, 2021 12:44
@mshustov mshustov requested a review from a team June 9, 2021 12:44
@mshustov mshustov requested review from a team as code owners June 9, 2021 12:44
@mshustov mshustov requested a review from a team June 9, 2021 12:44
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jun 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security changes LGTM

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes 🚀

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack Management changes to Snapshot and Restore LGTM. Didn't test locally.

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app services changes LGTM

Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting changes LGTM

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transform plugin edit LGTM

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana app changes LGTM - just a change of a comment

Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infra plugin changes LGTM, thank you!

Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Solution changes LGTM! 👍 Thanks for the cleanup here @mshustov! 🙂

Copy link
Contributor

@estermv estermv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack monitoring changes LGTM 🚀

@mshustov mshustov enabled auto-merge (squash) June 21, 2021 13:58
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit f3ec948 into elastic:master Jun 21, 2021
@mshustov mshustov deleted the cleanup-outdated-es-type-errors branch June 21, 2021 14:03
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 101741

mshustov added a commit to mshustov/kibana that referenced this pull request Jun 21, 2021
…01741)

* fix errors and update comments in Core

* fix errors or update comments in Security plugin

* update spaces test

* update task_manager files

* update comments in monitoring plugin

* fix errors in update comments in security_solutions

* fix errors and update comments in data_enhanced

* update fleet code

* update infra code

* update comment in trigger_actions_ui

* update comment in lens

* update comments in ES-UI code

* update typings for search

* update monitoring

* remove outdated export
# Conflicts:
#	x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/evaluate_condition.ts
#	x-pack/plugins/snapshot_restore/server/routes/api/snapshots.ts
mshustov added a commit that referenced this pull request Jun 21, 2021
…1741) (#102747)

* Cleanup outdated @elastic/elasticsearch client type errors (#101741)

* fix errors and update comments in Core

* fix errors or update comments in Security plugin

* update spaces test

* update task_manager files

* update comments in monitoring plugin

* fix errors in update comments in security_solutions

* fix errors and update comments in data_enhanced

* update fleet code

* update infra code

* update comment in trigger_actions_ui

* update comment in lens

* update comments in ES-UI code

* update typings for search

* update monitoring

* remove outdated export
# Conflicts:
#	x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/evaluate_condition.ts
#	x-pack/plugins/snapshot_restore/server/routes/api/snapshots.ts

* fix a result of wrong conflict resolution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.