Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Fix incorrect message displayed on importing Timeline Templates (#101288) #101881

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

machadoum
Copy link
Member

Backports the following commits to 7.x:

…tic#101288)

Context:
The import button can be used to import both timelines and timeline templates.
In theory, one imported file could have multiple timelines and timeline templates at the same time.

Solution:
Since the import endpoint only returns the total count and not the type of the imported documents.
It seems like that rewording "timeline(s)" to "item(s)" is the most straightforward fix that solves
the user problem.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@machadoum machadoum enabled auto-merge (squash) June 10, 2021 11:42
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.9MB 6.9MB -8.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@machadoum machadoum merged commit 59b05c4 into elastic:7.x Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants