Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting][Docs] Removing placeholder sections in docs #101953

Merged
merged 9 commits into from
Jun 21, 2021

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Jun 10, 2021

Summary

Recently restructured the alerting docs for this issue. Some of those changes required renaming pages and sections and some placeholder sections were left in in order not to break cross document links from ES docs and Observability docs.

With these PRs, those cross-document links have been updated:

This PR removes the placeholder sections.

@ymao1
Copy link
Contributor Author

ymao1 commented Jun 14, 2021

@elasticmachine merge upstream

@ymao1 ymao1 changed the title Removing placeholder prerequisite section [Alerting][Docs] Removing placeholder sections in docs Jun 15, 2021
@ymao1 ymao1 self-assigned this Jun 15, 2021
@ymao1 ymao1 added docs Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0 labels Jun 15, 2021
@ymao1 ymao1 marked this pull request as ready for review June 15, 2021 17:43
@ymao1 ymao1 requested a review from a team as a code owner June 15, 2021 17:43
@ymao1 ymao1 added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Jun 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@ymao1 ymao1 requested a review from gchaps June 16, 2021 12:32
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one minor comment. "Setup" should be "Set up".

@ymao1
Copy link
Contributor Author

ymao1 commented Jun 17, 2021

LGTM, with one minor comment. "Setup" should be "Set up".

Done!

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1
Copy link
Contributor Author

ymao1 commented Jun 21, 2021

@elasticmachine merge upstream

@ymao1 ymao1 added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 21, 2021
@ymao1 ymao1 merged commit f53fc8d into elastic:master Jun 21, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 21, 2021
* Removing placeholder prerequisite section

* Removing placeholder defining-rules and rule-management

* Fixing links

* Setup to set up

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 21, 2021
…2790)

* Removing placeholder prerequisite section

* Removing placeholder defining-rules and rule-management

* Fixing links

* Setup to set up

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: ymao1 <ying.mao@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed docs Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants