Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet + Integrations UI] Address UI Regressions in Fleet/Integrations #102250

Merged
merged 4 commits into from
Jun 16, 2021

Conversation

kpollich
Copy link
Member

Summary

This PR addresses two bugs that followed after migrating the Integrations UI to a separate Kibana app in #99848

Fixes #101771
Fixes #101785

Active Tab State in Integrations UI

Integrations tabs now properly display active state based on the current tab.

Screen Recording

Kapture 2021-06-15 at 13 32 32

Duplicate Breadcrumbs on Integrations Pages

We no longer display Integrations > Integrations on initial load, reducing UI shift for the breadcrumbs.

Screen Recording

Kapture 2021-06-15 at 13 34 36

@kpollich kpollich added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 labels Jun 15, 2021
@kpollich kpollich self-assigned this Jun 15, 2021
@kpollich kpollich requested a review from a team as a code owner June 15, 2021 17:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kpollich kpollich enabled auto-merge (squash) June 15, 2021 18:12
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 704.9KB 705.0KB +101.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 435.8KB 435.7KB -135.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kpollich kpollich merged commit a84293b into elastic:master Jun 16, 2021
@kpollich kpollich deleted the integrations-ui/address-regressions branch June 16, 2021 14:26
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 18, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 102250 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 102250 or prevent reminders by adding the backport:skip label.

kpollich added a commit to kpollich/kibana that referenced this pull request Jun 21, 2021
elastic#102250)

* Fix active tabs in integrations UI

Fixes elastic#101771

* Remove duplicate base breadcrumb

Fixes elastic#101785

* Fix i18n
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 21, 2021
kpollich added a commit that referenced this pull request Jun 21, 2021
#102250) (#102759)

* Fix active tabs in integrations UI

Fixes #101771

* Remove duplicate base breadcrumb

Fixes #101785

* Fix i18n
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 v8.0.0
Projects
None yet
4 participants