Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ILM locators #102313

Merged
merged 36 commits into from
Jun 21, 2021
Merged

ILM locators #102313

merged 36 commits into from
Jun 21, 2021

Conversation

streamich
Copy link
Contributor

@streamich streamich commented Jun 16, 2021 •
edited
Loading

Summary

Partially addresses #98107

This change removes and replaces ILM URL generator createIlmUrlGenerator with a new ILM locator.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Testing

ILM URL generator was used in two places (you can see them below). Both links are still working and are now generated using the locator.

(Add new data stream tutorial)

image

and here:

image

streamich added 30 commits May 14, 2021 17:23
@streamich
feat: 🎸 add url service types
66e3b42
@streamich
refactor: 💡 move locator types into its own folder
2fee1cc
@streamich
feat: 🎸 add abstract locator implementation
26a9cc2
@streamich
feat: 🎸 implement abstract locator client
306ae7b
@streamich
Merge remote-tracking branch 'upstream/master' into url-service-locators
8c444bc
@streamich
feat: 🎸 add browser-side locators service
ed4c671
@streamich
feat: 🎸 implement locator .getLocation()
d60760b
@streamich
feat: 🎸 implement navigate function
298530e
@streamich
feat: 🎸 implement locator service in /common folder
f93859f
@streamich
feat: 🎸 expose locators client on browser and server
a3f0ecd
@streamich
Merge remote-tracking branch 'upstream/master' into url-service-locators
4884733
@streamich
refactor: 💡 make locators async
2993127
@streamich
chore: 🤖 add deprecation notice to URL generators
9d5cb9d
@streamich
docs: ✏️ add deprecation notice to readme
5361362
@streamich
Merge remote-tracking branch 'upstream/master' into migrate-url-gener…
83fa1fe 
…ators
@streamich
Merge remote-tracking branch 'upstream/master' into migrate-url-gener…
46cd21a 
…ators
@streamich
feat: 🎸 create management app locator
54f759d
@streamich
refactor: 💡 simplify management locator
79ca515
@streamich
feat: 🎸 export management app locator from plugin contract
8d2b917
@streamich
feat: 🎸 implement ILM locator
a46f7b4
@streamich
feat: 🎸 improve share plugin exports
ca4a29a
@streamich
Merge remote-tracking branch 'upstream/master' into migrate-url-gener…
531e329 
…ators
@streamich
Merge remote-tracking branch 'upstream/master' into migrate-url-gener…
88811eb 
…ators
@streamich
Merge remote-tracking branch 'upstream/master' into migrate-url-gener…
862d67e 
…ators
@streamich
feat: 🎸 improve management app locator
8345808
@streamich
feat: 🎸 add useLocatorUrl React hook
8f9a347
@streamich
feat: 🎸 add .getUrl() method to locators
bae728a
@streamich
feat: 🎸 migrate ILM app to use URL locators
e07203a
@streamich
fix: 🐛 correct typescript errors
975f9e5
@streamich
Merge remote-tracking branch 'upstream/master' into ilm-locators
cb7d5eb
@streamich streamich marked this pull request as ready for review June 19, 2021 08:35
@streamich streamich requested a review from a team June 19, 2021 08:35
@streamich streamich requested review from a team as code owners June 19, 2021 08:35
@streamich streamich added Feature:SharingURLs Short URLs and Share URL features release_note:skip Skip the PR/issue when compiling release notes review Team:AppServices v7.14.0 v8.0.0 labels Jun 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@streamich
Copy link
Contributor Author

@elasticmachine merge upstream

mbondyra
mbondyra approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KibanaApp changes look good.

@streamich streamich requested review from ppisljar and yuliacech June 21, 2021 07:54
@vadimkibana
Copy link
Contributor

@elasticmachine merge upstream

@streamich streamich requested a review from ppisljar June 21, 2021 09:50
ppisljar
ppisljar approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@streamich streamich requested a review from yuliacech June 21, 2021 18:01
yuliacech
yuliacech approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @streamich,
thanks a lot for migrating ILM from url generators to url locators! Code changes LGTM, tested locally and all worked 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
share 53 55 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
indexLifecycleManagement 5 4 -1
management 39 40 +1
share 68 78 +10
total +10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexLifecycleManagement 248.6KB 248.6KB -1.0B
indexManagement 1.3MB 1.3MB -404.0B
total -405.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
share 6 7 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
indexLifecycleManagement 50.3KB 50.1KB -249.0B
indexManagement 36.6KB 36.8KB +232.0B
management 16.2KB 16.2KB +17.0B
share 71.8KB 73.8KB +2.0KB
total +2.0KB
Unknown metric groups

API count

id before after diff
indexLifecycleManagement 5 4 -1
management 39 40 +1
share 85 102 +17
total +17

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit 1fb2640 into elastic:master Jun 21, 2021
@streamich streamich mentioned this pull request Jun 21, 2021
Merged
streamich added a commit that referenced this pull request Jun 21, 2021
@streamich @vadimkibana @kibanamachine
ILM locators (#102313) (#102814)
0322147 
* feat: 🎸 add url service types

* refactor: 💡 move locator types into its own folder

* feat: 🎸 add abstract locator implementation

* feat: 🎸 implement abstract locator client

* feat: 🎸 add browser-side locators service

* feat: 🎸 implement locator .getLocation()

* feat: 🎸 implement navigate function

* feat: 🎸 implement locator service in /common folder

* feat: 🎸 expose locators client on browser and server

* refactor: 💡 make locators async

* chore: 🤖 add deprecation notice to URL generators

* docs: ✏️ add deprecation notice to readme

* feat: 🎸 create management app locator

* refactor: 💡 simplify management locator

* feat: 🎸 export management app locator from plugin contract

* feat: 🎸 implement ILM locator

* feat: 🎸 improve share plugin exports

* feat: 🎸 improve management app locator

* feat: 🎸 add useLocatorUrl React hook

* feat: 🎸 add .getUrl() method to locators

* feat: 🎸 migrate ILM app to use URL locators

* fix: 🐛 correct typescript errors

* Fix TypeScript errors in mock

* Fix ILM locator unit tests

* style: 💄 shorten import

Co-authored-by: Vadim Kibana <vadimkibana@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Vadim Kibana <vadimkibana@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@streamich streamich mentioned this pull request Jun 22, 2021
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadimkibana vadimkibana vadimkibana left review comments

@ppisljar ppisljar ppisljar approved these changes

@yuliacech yuliacech yuliacech approved these changes

@mbondyra mbondyra mbondyra approved these changes

Assignees
No one assigned
Labels
Feature:SharingURLs Short URLs and Share URL features release_note:skip Skip the PR/issue when compiling release notes review v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@streamich @elasticmachine @vadimkibana @kibanamachine @mbondyra @yuliacech @ppisljar