Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Error on array values in math #102371

Merged
merged 4 commits into from
Jun 21, 2021
Merged

[Lens] Error on array values in math #102371

merged 4 commits into from
Jun 21, 2021

Conversation

wylieconlon
Copy link
Contributor

@wylieconlon wylieconlon commented Jun 16, 2021 •
edited
Loading

Fixes #102249

Screen Shot 2021-06-17 at 11 42 42 AM

Checklist

Delete any items that are not applicable to this PR.

@wylieconlon wylieconlon added release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 16, 2021
@wylieconlon wylieconlon marked this pull request as ready for review June 17, 2021 15:50
@wylieconlon wylieconlon requested a review from a team June 17, 2021 15:50
@wylieconlon wylieconlon requested a review from a team as a code owner June 17, 2021 15:50
@wylieconlon wylieconlon added Team:AppServices Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jun 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

flash1293
flash1293 approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected, LGTM

@botelastic botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Jun 18, 2021
@wylieconlon
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +32.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressions 209.1KB 209.6KB +505.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@wylieconlon wylieconlon requested review from ppisljar and dokmic June 21, 2021 17:44
streamich
streamich approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM.

@wylieconlon wylieconlon merged commit 3b0be1b into elastic:master Jun 21, 2021
@wylieconlon wylieconlon deleted the lens/no-array-math branch June 21, 2021 18:46
@kibanamachine kibanamachine mentioned this pull request Jun 21, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 21, 2021
@kibanamachine
[Lens] Error on array values in math (elastic#102371)
b88f0ae 
* [Lens] Error on array values in math

* Update error messages

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Jun 21, 2021
@kibanamachine
[Lens] Error on array values in math (#102371) (#102793)
650ee93 
* [Lens] Error on array values in math

* Update error messages

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Wylie Conlon <william.conlon@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamich streamich streamich approved these changes

@flash1293 flash1293 flash1293 approved these changes

@ppisljar ppisljar Awaiting requested review from ppisljar

@dokmic dokmic Awaiting requested review from dokmic

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Throw error on array values in formulas
5 participants
@wylieconlon @elasticmachine @kibanamachine @flash1293 @streamich