Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability] [Cases] Fix Cases navigation #102429

Merged
merged 5 commits into from
Jun 21, 2021
Merged

[Observability] [Cases] Fix Cases navigation #102429

merged 5 commits into from
Jun 21, 2021

Conversation

stephmilovic
Copy link
Contributor

Summary

Change from navigateToApp to navigateToUrl to fix issue with breadcrumbs.

Before:
bcbug

After:
navigate_to_url

Checklist

@stephmilovic stephmilovic added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Observability Team label for Observability Team (for things that are handled across all of observability) Feature:Cases Cases feature v7.14.0 Feature:RAC label obsolete labels Jun 16, 2021
@stephmilovic stephmilovic requested review from smith and XavierM June 16, 2021 21:58
@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 464.2KB 464.5KB +274.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic stephmilovic merged commit 491b0d1 into elastic:master Jun 21, 2021
@stephmilovic stephmilovic deleted the obs_cases_onclick_fixx branch June 21, 2021 16:54
@stephmilovic stephmilovic mentioned this pull request Jun 21, 2021
Merged
stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Jun 21, 2021
@stephmilovic
[Observability] [Cases] Fix Cases navigation (elastic#102429)
180e3ef
stephmilovic added a commit that referenced this pull request Jun 21, 2021
@stephmilovic
[Observability] [Cases] Fix Cases navigation (#102429) (#102795)
d17a353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smith smith smith approved these changes

@XavierM XavierM Awaiting requested review from XavierM

Assignees
No one assigned
Labels
Feature:Cases Cases feature Feature:RAC label obsolete release_note:skip Skip the PR/issue when compiling release notes Team:Observability Team label for Observability Team (for things that are handled across all of observability) v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephmilovic @kibanamachine @smith