Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Endpoint] Rename Unisolating and other like words to Releasing #102582

Merged
merged 5 commits into from
Jun 22, 2021
Merged

[Security Solution][Endpoint] Rename Unisolating and other like words to Releasing #102582

merged 5 commits into from
Jun 22, 2021

Conversation

paul-tavares
Copy link
Contributor

@paul-tavares paul-tavares commented Jun 17, 2021 •
edited
Loading

Summary

  • Renames use of Unisolating and like words to Releasing

olm-1320-rename-unisolate

@paul-tavares paul-tavares added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 17, 2021
@paul-tavares paul-tavares self-assigned this Jun 17, 2021
@paul-tavares paul-tavares marked this pull request as ready for review June 22, 2021 14:14
@paul-tavares paul-tavares requested a review from a team as a code owner June 22, 2021 14:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

kevinlog
kevinlog reviewed Jun 22, 2021
View reviewed changes
x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.tsx
@@ -272,7 +272,7 @@ export const EndpointList = () => {
},
{
field: 'host_status',
width: '9%',
width: '14%',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank your for adjusting this!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was driving me nuts when there were more than one action pending. we might need to adjust further :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it out locally on my small mac screen. The common statuses look good, however the multiple pending status case is still cut off.

image

I think we could still take a bit more width from hostname and/or ips if we wanted to give it more room. The tooltip helps with the multiple pending status, though.

image

kevinlog
kevinlog approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@kevinlog kevinlog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

parkiino
parkiino reviewed Jun 22, 2021
View reviewed changes
x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/translations.ts
@@ -26,7 +26,7 @@ export const ACTIVITY_LOG = {
unisolatedAction: i18n.translate(
'xpack.securitySolution.endpointDetails.activityLog.logEntry.action.unisolated',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know if this is necessary but should we also change the id as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe. I left it only because in the code we are still using unisolate through api's etc.

@parkiino
Copy link
Contributor

@paul-tavares also question -- are we only changing the wording for the endpoint list or also for the alert details flyout side as well?

@paul-tavares
Copy link
Contributor Author

@parkiino this PR should cover all use cases - including those in the Alert details. If you see something missing let me know and I'll include it

parkiino
parkiino approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@parkiino parkiino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay thanks for grabbing alert details too!

ashokaditya
ashokaditya approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.9MB 6.9MB -40.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @paul-tavares

@paul-tavares paul-tavares merged commit 19d2d17 into elastic:master Jun 22, 2021
@paul-tavares paul-tavares deleted the task/olm-1320-rename-unisolate-text branch June 22, 2021 16:25
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 22, 2021
@paul-tavares @kibanamachine
[Security Solution][Endpoint] Rename Unisolating and other like wor…
fe8cb6d 
…ds to `Releasing` (elastic#102582)

* Update all instances of `unisolate` to `release` (along with variation of unisolate)
* just width of Agent Status column on endpoint list
@kibanamachine kibanamachine mentioned this pull request Jun 22, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 22, 2021
@kibanamachine @paul-tavares
[Security Solution][Endpoint] Rename Unisolating and other like wor…
fd15a1f 
…ds to `Releasing` (#102582) (#102960)

* Update all instances of `unisolate` to `release` (along with variation of unisolate)
* just width of Agent Status column on endpoint list

Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlog kevinlog kevinlog approved these changes

@parkiino parkiino parkiino approved these changes

@ashokaditya ashokaditya ashokaditya approved these changes

Assignees

@paul-tavares paul-tavares

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@paul-tavares @elasticmachine @parkiino @kibanamachine @ashokaditya @kevinlog