Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kbn/test/es] remove unnecessary es user management logic #102584

Merged

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jun 17, 2021

I'm auditing and reworking some of the es/kibana initialization logic used by the FTR and found some ES user management logic which seems to have been running fine for years but also doesn't do anything that isn't already handled by @kbn/es and the security service in test/common/services.

This removes the legacy/unnecessary logic.

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels Jun 17, 2021
@spalger
Copy link
Contributor Author

spalger commented Jun 21, 2021

@elasticmachine merge upstream

@spalger spalger marked this pull request as ready for review June 21, 2021 17:45
@spalger spalger requested review from a team as code owners June 21, 2021 17:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger enabled auto-merge (squash) June 21, 2021 17:45
@spalger spalger added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 21, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 3084de6 into elastic:master Jun 21, 2021
@spalger spalger deleted the remove/unnecessary-es-user-setup-logic branch June 21, 2021 22:36
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 21, 2021
…2584)

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 22, 2021
…102831)

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Spencer <email@spalger.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants