Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Use docLinks service to link to the doc #102660

Merged
merged 3 commits into from
Jun 21, 2021
Merged

[Fleet] Use docLinks service to link to the doc #102660

merged 3 commits into from
Jun 21, 2021

Conversation

nchaulet
Copy link
Member

Summary

#100371

Use dockLinks service to link to the doc from Fleet UI.
This allow to link to the correct doc version

@nchaulet nchaulet added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 18, 2021
@nchaulet nchaulet requested a review from Zacqary June 18, 2021 15:47
@nchaulet nchaulet requested a review from a team as a code owner June 18, 2021 15:47
@nchaulet nchaulet self-assigned this Jun 18, 2021
@nchaulet nchaulet requested a review from a team as a code owner June 18, 2021 15:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

kpollich
kpollich approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@nchaulet nchaulet enabled auto-merge (squash) June 21, 2021 12:29
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 679.2KB 679.3KB +138.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 410.7KB 411.5KB +787.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 307a5b2 into elastic:master Jun 21, 2021
@nchaulet nchaulet deleted the feature-use-doclinks-fleet branch June 21, 2021 13:47
@kibanamachine kibanamachine mentioned this pull request Jun 21, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 21, 2021
@nchaulet @kibanamachine
[Fleet] Use docLinks service to link to the doc (elastic#102660)
78c1967
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 21, 2021
@kibanamachine @nchaulet
[Fleet] Use docLinks service to link to the doc (#102660) (#102741)
4f99200 
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
@lcawl lcawl mentioned this pull request Jun 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@Zacqary Zacqary Awaiting requested review from Zacqary

Assignees

@nchaulet nchaulet

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nchaulet @elasticmachine @kibanamachine @pgayvallet @kpollich