[Security Solution] show case names in isolation success message #102664

kevinlog · 2021-06-18T18:13:40Z

Summary

Addresses: #102331

Adds the Case names to the Isolation success message.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

kevinlog · 2021-06-21T19:16:11Z

@elasticmachine merge upstream

elasticmachine · 2021-06-21T19:16:43Z

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

cnasikas · 2021-06-22T07:49:40Z

x-pack/plugins/security_solution/public/detections/components/host_isolation/isolate.tsx

    cancelCallback: () => void;
  }) => {
    const [comment, setComment] = useState('');
    const [isIsolated, setIsIsolated] = useState(false);

+    const caseIds: string[] = casesInfo.map((caseInfo): string => {


I think is best to use the useMemo here and not in caseCount. The reason is that iterating over an array could be expensive but accessing an array attribute (length) is not.

cnasikas · 2021-06-22T07:52:00Z

x-pack/plugins/security_solution/public/detections/components/host_isolation/isolate.tsx

@@ -47,7 +52,7 @@ export const IsolateHost = React.memo(
      []
    );

-    const caseCount: number = useMemo(() => caseIds.length, [caseIds]);
+    const caseCount: number = useMemo(() => casesInfo.length, [casesInfo]);


I think that the overhead of the useMemo here surpass the benefits using it. const caseCount: number = casesInfo.length would not cause re-renders as the value is a primitive type.

cnasikas · 2021-06-22T07:52:44Z

x-pack/plugins/security_solution/public/detections/components/host_isolation/unisolate.tsx

    cancelCallback: () => void;
  }) => {
    const [comment, setComment] = useState('');
    const [isUnIsolated, setIsUnIsolated] = useState(false);

+    const caseIds: string[] = casesInfo.map((caseInfo): string => {


https://github.com/elastic/kibana/pull/102664/files#r655965043

cnasikas · 2021-06-22T08:12:10Z

x-pack/plugins/cases/server/client/cases/get.ts

@@ -75,20 +77,53 @@ export const getCaseIDsByAlertID = async (
      Operations.getCaseIDsByAlertID.savedObjectType
    );

+    // This will likely only return one comment saved object, the response aggregation will contain


This will likely only return one comment saved object

What will be the response if the same alert is attached to multiple cases?

The service requests page: 1, perPage: 1 so I think it'll only ever return 1 comment. But the aggregations of that single comment will have all the unique case IDs that we need.

cnasikas · 2021-06-22T08:16:39Z

x-pack/plugins/cases/server/client/cases/get.ts

+      return [];
+    }
+
+    const casesInfo = await caseService.getCases({


Now that we fetch the cases I am wondering if there is any benefit with the aggregation. Do we still need it? The comments will have the case id in the reference field, right?

Christos and I talked about this offline and we do still need the aggregation because the alert ID could appear in multiple comment saved objects. So I think we're ok to leave this as it is.

kibanamachine · 2021-06-22T17:32:47Z

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`cases`	401	403	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	6.9MB	6.9MB	+152.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`cases`	126.6KB	126.8KB	+171.0B

Unknown metric groups

API count

id	before	after	diff
`cases`	437	439	+2

History

💚 Build #133109 succeeded 28c1817
💔 Build #132978 failed 9ee5d41
💔 Build #132965 failed 2f8afb8
💔 Build #132946 failed 9a102f5
💔 Build #132863 failed d09829e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2021-06-22T18:04:42Z

💔 Backport failed

Status	Branch	Result
❌	7.x	Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 102664

…stic#102664) # Conflicts: # x-pack/plugins/security_solution/server/endpoint/routes/actions/isolation.ts

…2664) (#102974) # Conflicts: # x-pack/plugins/security_solution/server/endpoint/routes/actions/isolation.ts

show case names in isolateion success message

9b5a386

kevinlog changed the title ~~[Security Solution] show case names in isolateion success message~~ [Security Solution] show case names in isolation success message Jun 18, 2021

kevinlog and others added 3 commits June 18, 2021 14:48

fix types

81bfb58

Returning title in get cases by alert id response

b65ed84

Updating docs

6ea7371

jonathan-buttner requested a review from cnasikas June 21, 2021 18:19

kevinlog marked this pull request as ready for review June 21, 2021 19:15

kevinlog requested review from a team as code owners June 21, 2021 19:15

Merge branch 'master' into bug/add-case-names-to-isolation-success

d09829e

kevinlog added the Team:Defend Workflows “EDR Workflows” sub-team of Security Solution label Jun 21, 2021

kevinlog added v7.14.0 release_note:feature Makes this part of the condensed release notes labels Jun 21, 2021

kevinlog added 3 commits June 21, 2021 18:12

fix types and tests

9a102f5

fix types

2f8afb8

adjust types

9ee5d41

cnasikas reviewed Jun 22, 2021

View reviewed changes

cnasikas approved these changes Jun 22, 2021

View reviewed changes

kevinlog and others added 2 commits June 22, 2021 08:24

fix test

28c1817

Unifying tests and changing names

0e5bf1f

jonathan-buttner approved these changes Jun 22, 2021

View reviewed changes

kevinlog added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 22, 2021

kevinlog merged commit bfbe6ab into elastic:master Jun 22, 2021

kevinlog deleted the bug/add-case-names-to-isolation-success branch June 22, 2021 18:01

kevinlog mentioned this pull request Jun 22, 2021

[7.x] [Security Solution] show case names in isolation success message (#102664) #102974

Merged

kevinlog added a commit to kevinlog/kibana that referenced this pull request Jun 22, 2021

[Security Solution] show case names in isolation success message (ela…

7bc4804

…stic#102664) # Conflicts: # x-pack/plugins/security_solution/server/endpoint/routes/actions/isolation.ts

kevinlog added a commit that referenced this pull request Jun 22, 2021

[Security Solution] show case names in isolation success message (#10…

3d4521b

…2664) (#102974) # Conflicts: # x-pack/plugins/security_solution/server/endpoint/routes/actions/isolation.ts

nastasha-solomon mentioned this pull request Mar 9, 2022

[BUG] Example response in "Find Cases by Alert" topic is outdated elastic/security-docs#1694

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] show case names in isolation success message #102664

[Security Solution] show case names in isolation success message #102664

kevinlog commented Jun 18, 2021 •

edited

Loading

kevinlog commented Jun 21, 2021

elasticmachine commented Jun 21, 2021

cnasikas Jun 22, 2021

cnasikas Jun 22, 2021 •

edited

Loading

cnasikas Jun 22, 2021

cnasikas Jun 22, 2021 •

edited

Loading

jonathan-buttner Jun 22, 2021

cnasikas Jun 22, 2021 •

edited

Loading

jonathan-buttner Jun 22, 2021

kibanamachine commented Jun 22, 2021

API count

kibanamachine commented Jun 22, 2021

[Security Solution] show case names in isolation success message #102664

[Security Solution] show case names in isolation success message #102664

Conversation

kevinlog commented Jun 18, 2021 • edited Loading

Summary

Checklist

kevinlog commented Jun 21, 2021

elasticmachine commented Jun 21, 2021

cnasikas Jun 22, 2021

Choose a reason for hiding this comment

cnasikas Jun 22, 2021 • edited Loading

Choose a reason for hiding this comment

cnasikas Jun 22, 2021

Choose a reason for hiding this comment

cnasikas Jun 22, 2021 • edited Loading

Choose a reason for hiding this comment

jonathan-buttner Jun 22, 2021

Choose a reason for hiding this comment

cnasikas Jun 22, 2021 • edited Loading

Choose a reason for hiding this comment

jonathan-buttner Jun 22, 2021

Choose a reason for hiding this comment

kibanamachine commented Jun 22, 2021

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

History

kibanamachine commented Jun 22, 2021

💔 Backport failed

kevinlog commented Jun 18, 2021 •

edited

Loading

cnasikas Jun 22, 2021 •

edited

Loading

cnasikas Jun 22, 2021 •

edited

Loading

cnasikas Jun 22, 2021 •

edited

Loading