-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Fix time shift usability issues #102709
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wylieconlon the problem with this is the dropdown covers the helper text and, as soon as you click "time shift" in the popover, we move the user into the dropdown for fewer clicks & what I assume are good accessibility reasons. I think |
@elasticmachine merge upstream |
@wylieconlon @ghudgins If you are happy with this solution, I am happy - I think it's better than the current placeholder and we can give it a shot and see whether this problem is still happening. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Tested locally 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AppServices regular expression change LGTM.
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Fixes #102116
Fixes #102405
This PR fixes a few usability issues with time shift in Lens:
I'm not sure about the placeholder change. We thought about something like "Enter a time shift. Type to specify custom values (e.g. 8w)" but the space is way to tight for that. The best i could do is "Type custom values (e.g. 8w)", but even that won't be visible on all screen widths: