Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Adding refresh to ensure status is updated #102742

Merged
merged 1 commit into from
Jun 21, 2021
Merged

[Cases] Adding refresh to ensure status is updated #102742

merged 1 commit into from
Jun 21, 2021

Conversation

jonathan-buttner
Copy link
Contributor

This PR addresses a flaky test where the alert status isn't always changing as it is supposed to. I added in an index refresh to ensure that the status is changed before we query for it.

Flaky test: #102551

@jonathan-buttner jonathan-buttner added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Feature:Cases Cases feature v7.14.0 labels Jun 21, 2021
@jonathan-buttner jonathan-buttner requested a review from a team as a code owner June 21, 2021 14:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@jonathan-buttner jonathan-buttner linked an issue Jun 21, 2021 that may be closed by this pull request
Failing test: X-Pack Case API Integration Tests.x-pack/test/case_api_integration/security_and_spaces/tests/common/comments/post_comment·ts - cases security and spaces enabled: basic Common post_comment alerts should change the status of the alert if sync alert is on #102551
Closed
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jonathan-buttner jonathan-buttner added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 21, 2021
@jonathan-buttner jonathan-buttner merged commit 3589ade into elastic:master Jun 21, 2021
@jonathan-buttner jonathan-buttner deleted the cases-alert-status-test branch June 21, 2021 16:29
@kibanamachine kibanamachine mentioned this pull request Jun 21, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 21, 2021
@jonathan-buttner @kibanamachine
Adding refresh to ensure status is updated (elastic#102742)
0262dc3
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 21, 2021
@kibanamachine @jonathan-buttner
Adding refresh to ensure status is updated (#102742) (#102768)
36d94ee 
Co-authored-by: Jonathan Buttner <56361221+jonathan-buttner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnasikas cnasikas cnasikas approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@jonathan-buttner @elasticmachine @kibanamachine @cnasikas