Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Ability to filter by type:package #102754

Merged
merged 1 commit into from
Jun 22, 2021
Merged

[Fleet] Ability to filter by type:package #102754

merged 1 commit into from
Jun 22, 2021

Conversation

jloleysens
Copy link
Contributor

Summary

Continuation of #102227. See that issue for steps to test. This contribution adds the ability to type type:package to the search bar filter for all packages or to add additional scope for the search term.

See comment #102227 (comment)

Checklist

Delete any items that are not applicable to this PR.

@jloleysens jloleysens added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 21, 2021
@jloleysens jloleysens requested a review from a team as a code owner June 21, 2021 14:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Feature:Fleet)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jloleysens jloleysens requested a review from kpollich June 21, 2021 14:57
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 438.7KB 439.1KB +415.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nchaulet
nchaulet approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

kpollich
kpollich approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 Thank you! Looks great and the test cases are super helpful.

@jloleysens jloleysens merged commit 60a3d5d into elastic:master Jun 22, 2021
@jloleysens jloleysens deleted the fleet/filter-by-type-package branch June 22, 2021 12:12
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 22, 2021
@jloleysens @kibanamachine
added ability to filter in global search by "type:package" (elastic#1…
afa7654 
…02754)
@kibanamachine kibanamachine mentioned this pull request Jun 22, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 22, 2021
@kibanamachine @jloleysens
added ability to filter in global search by "type:package" (#102754) (#…
d6a4a50 
…102898)

Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

@nchaulet nchaulet nchaulet approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Fleet Fleet team's agent central management project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jloleysens @elasticmachine @kibanamachine @nchaulet @kpollich