[Lens] Avoid suggestion rendering and evaluation on fullscreen mode

[dej611]

Summary

Avoid to compute suggestions when the Formula editor is in fullscreen mode: expecially when editing a formula this should lead to better performance.

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[wylieconlon]

@dej611 LGTM, although we might not need this line of CSS any more: .lnsFrameLayout-isFullscreen .lnsFrameLayout__suggestionPanel. There will definitely be a rerender and refetch when we show suggestions again, but it should improve the performance while viewing just the main chart.

[dej611]

@dej611 LGTM, although we might not need this line of CSS any more: .lnsFrameLayout-isFullscreen .lnsFrameLayout__suggestionPanel. There will definitely be a rerender and refetch when we show suggestions again, but it should improve the performance while viewing just the main chart.

Yes, the fix aims at improve the performance in a specific context, the formula fullscreen, slowing down a bit the collapse transition. Ideally it's multiple speedups (formula editing) vs one slowdown (editor collapse).

[MichaelMarcialis]

Left one small nit about a CSS comment, but LGTM otherwise. Approving.

[MichaelMarcialis]

Small nit, but might be worth updating this comment to no longer reference suggestions.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 1a31713
• Storybooks Preview

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
lens	1.5MB	1.5MB	-217.0B

History

• 💚 Build #133041 succeeded afdce67
• 💚 Build #132740 succeeded ca15387

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kibanamachine]

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.