Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Add right permission for unmapped field test in cloud env #102853

Conversation

kertal
Copy link
Member

@kertal kertal commented Jun 22, 2021

Summary

This PR fixes testing of unmapped fields in cloud environment, by adding the right permission for the indices to prevent the test to fail before it's execute. Furthermore it improves execution time of the test by changing the default time range via uiSettings, which is faster than using the time picker.

Fixes #97555
Fixes #92300

Note: tested it in my own cloud env, before this fix, didn't work at all due to permission issues

Checklist

@kertal kertal added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure :KibanaApp/fix-it-week labels Jun 22, 2021
@kertal kertal self-assigned this Jun 22, 2021
@kertal kertal marked this pull request as ready for review June 22, 2021 08:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0 v7.13.3 labels Jun 22, 2021
@kertal
Copy link
Member Author

kertal commented Jun 24, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

@kertal kertal added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 24, 2021
@kertal kertal merged commit 507ab0e into elastic:master Jun 24, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.13 Commit could not be cherrypicked due to conflicts
7.x

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 102853

kibanamachine added a commit that referenced this pull request Jun 24, 2021
…102853) (#103221)

Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.3 v7.14.0 v8.0.0
Projects
None yet
4 participants