-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Add right permission for unmapped field test in cloud env #102853
Merged
kertal
merged 2 commits into
elastic:master
from
kertal:kertal-pr-2021-06-22-fix-unmapped-field-test-for-cloud
Jun 24, 2021
Merged
[Discover] Add right permission for unmapped field test in cloud env #102853
kertal
merged 2 commits into
elastic:master
from
kertal:kertal-pr-2021-06-22-fix-unmapped-field-test-for-cloud
Jun 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
added
Feature:Discover
Discover Application
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
:KibanaApp/fix-it-week
labels
Jun 22, 2021
Pinging @elastic/kibana-app (Team:KibanaApp) |
kertal
added
release_note:skip
Skip the PR/issue when compiling release notes
v7.14.0
v8.0.0
v7.13.3
labels
Jun 22, 2021
@elasticmachine merge upstream |
dimaanj
approved these changes
Jun 24, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @kertal |
kertal
added
the
auto-backport
Deprecated - use backport:version if exact versions are needed
label
Jun 24, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 24, 2021
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
Feature:Discover
Discover Application
release_note:skip
Skip the PR/issue when compiling release notes
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v7.13.3
v7.14.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes testing of unmapped fields in cloud environment, by adding the right permission for the indices to prevent the test to fail before it's execute. Furthermore it improves execution time of the test by changing the default time range via uiSettings, which is faster than using the time picker.
Fixes #97555
Fixes #92300
Note: tested it in my own cloud env, before this fix, didn't work at all due to permission issues
Checklist