-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Functional tests - explicitly delete jobs after setupModule tests #102882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheyos
added
:ml
test_ui_functional
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.14.0
v7.13.3
labels
Jun 22, 2021
Pinging @elastic/ml-ui (:ml) |
peteharverson
approved these changes
Jun 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pheyos
added
the
auto-backport
Deprecated - use backport:version if exact versions are needed
label
Jun 22, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 22, 2021
elastic#102882) This PR explicitly deletes the jobs created by the `setupModule` tests.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 22, 2021
elastic#102882) This PR explicitly deletes the jobs created by the `setupModule` tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
:ml
release_note:skip
Skip the PR/issue when compiling release notes
test_ui_functional
v7.13.3
v7.14.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR explicitly deletes the jobs created by the
setupModule
tests.Details
There were cases where the
setupModule
tests timed out while waiting for a created job to finish. In some of those cases thecleanMlIndices
failed in the suite'safter
method, causing follow-up issues. With this PR we make sure that the jobs (and corresponding datafeeds) are force-deleted via the ES-API, so nothing is left behind after cleanup phase of the suite.