Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Update dimension panel copy to suggested one #102890

Merged
merged 1 commit into from
Jun 22, 2021
Merged

[Lens] Update dimension panel copy to suggested one #102890

merged 1 commit into from
Jun 22, 2021

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Jun 22, 2021

Summary

Fixes #78814

  • Dimension panel title has no longer configuration in it (does it still need i18n?)
  • Rewritten wrong field error message

Screenshot 2021-06-22 at 12 54 22

Screenshot 2021-06-22 at 12 52 52

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 22, 2021
@dej611 dej611 requested a review from a team June 22, 2021 10:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

flash1293
flash1293 approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, didn't test

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB -9.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 merged commit a2e7b38 into elastic:master Jun 22, 2021
@dej611 dej611 deleted the fix/78814 branch June 22, 2021 14:30
@kibanamachine kibanamachine mentioned this pull request Jun 22, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 22, 2021
@dej611 @kibanamachine
[Lens] Update dimension panel copy to suggested one (elastic#102890)
a6cfe2d
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 22, 2021
@kibanamachine @dej611
[Lens] Update dimension panel copy to suggested one (#102890) (#102925)
a10fb12 
Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve dimension panel copy text
4 participants
@dej611 @elasticmachine @kibanamachine @flash1293