Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Improve default port experience in the settings UI #102982

Merged

Conversation

nchaulet
Copy link
Member

Summary

Resolve #102623

The different default ports we have could be confusing for the user, that PR try to help user to better understand what port will be used in the settings flyout.

  • In the confirm modal, always show the port even for default http|https port (80, 443)
  • Add default port in the input label.

UI Changes

Screen Shot 2021-06-22 at 2 26 25 PM

Screen Shot 2021-06-22 at 2 27 22 PM

cc @mostlyjason

@nchaulet nchaulet added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 22, 2021
@nchaulet nchaulet self-assigned this Jun 22, 2021
@nchaulet nchaulet requested a review from a team as a code owner June 22, 2021 18:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 473 474 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1014 1016 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 690.2KB 690.6KB +457.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 440.6KB 441.1KB +522.0B
Unknown metric groups

API count

id before after diff
fleet 1106 1108 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet enabled auto-merge (squash) June 22, 2021 21:46
@nchaulet nchaulet requested a review from kpollich June 23, 2021 11:20
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 23, 2021
…103079)

Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
@nchaulet nchaulet deleted the feature-102623-improve-settings-port branch June 23, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Incorrect default Fleet Server port on self-managed clusters
4 participants