Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Unskip and improve sidebar filter functional test #102986

Merged
merged 3 commits into from
Jun 24, 2021
Merged

[Discover] Unskip and improve sidebar filter functional test #102986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f459d40
Unskip and harden sidebar filter functional test
kertal Jun 22, 2021
d94128f
Update discover_page.ts
kertal Jun 23, 2021
02475db
Merge branch 'master' into kertal-pr-2021-06-22-fix-functional-sideba…
kibanamachine Jun 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions test/functional/apps/discover/_sidebar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const PageObjects = getPageObjects(['common', 'discover', 'timePicker']);
const testSubjects = getService('testSubjects');

// Failing: See https://github.com/elastic/kibana/issues/101449
describe.skip('discover sidebar', function describeIndexTests() {
describe('discover sidebar', function describeIndexTests() {
before(async function () {
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional');
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/discover');
Expand Down
5 changes: 4 additions & 1 deletion test/functional/page_objects/discover_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,10 @@ export class DiscoverPageObject extends FtrService {

public async closeSidebarFieldFilter() {
await this.testSubjects.click('toggleFieldFilterButton');
await this.testSubjects.missingOrFail('filterSelectionPanel');

await this.retry.waitFor('sidebar filter closed', async () => {
return !(await this.testSubjects.exists('filterSelectionPanel'));
});
}

public async waitForChartLoadingComplete(renderCount: number) {
Expand Down