Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [App Search] Migrate Source Engines & Crawler pages to new page template (#102848) #103030

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

cee-chen
Copy link
Contributor

Backports the following commits to 7.x:

…ate (elastic#102848)

* Convert meta engines Source Engines view to new page template

* Convert CrawlerLanding to new page template

* Convert CrawlerOverview to new page template

* Update routers

* Misc Source Engines UI polish

- move away from color=secondary, EUI is eventually deprecating it
- add (+) icon to match other views

* Fix bad merge conflict
# Conflicts:
#	x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_overview.test.tsx
#	x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_overview.tsx
#	x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_router.test.tsx
#	x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_router.tsx
@cee-chen cee-chen enabled auto-merge (squash) June 23, 2021 00:34
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.1MB 2.1MB -657.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen merged commit a2f1ecc into elastic:7.x Jun 23, 2021
@cee-chen cee-chen deleted the backport/7.x/pr-102848 branch June 23, 2021 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants