Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

persistable state migrations #103680

Merged
merged 8 commits into from
Jul 7, 2021
Merged

persistable state migrations #103680

merged 8 commits into from
Jul 7, 2021

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Jun 29, 2021 •
edited
Loading

Summary

Embeddable exposed getMigrationVersions which returned list of versions that have a migration registered.

This PR replaces that with getAllMigrations function on PersistableStateService that should return an object with all versions for which migrations exist mapped to an actual migration function for that verison.

This makes it much easier to consume migrations. Example was added as well to embeddable examples plugin.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@ppisljar ppisljar requested a review from a team as a code owner June 29, 2021 14:49
@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Jun 29, 2021
@ppisljar ppisljar force-pushed the persistable_stae branch from dfe4987 to dfecf0e Compare July 5, 2021 13:23
@ppisljar ppisljar requested a review from a team as a code owner July 5, 2021 13:23
@ppisljar ppisljar added release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0 labels Jul 5, 2021
@ppisljar ppisljar force-pushed the persistable_stae branch from dfecf0e to 57ff3c8 Compare July 5, 2021 15:49
@ppisljar ppisljar force-pushed the persistable_stae branch from 851df39 to 82401dc Compare July 6, 2021 07:56
streamich
streamich reviewed Jul 6, 2021
View reviewed changes
Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand exactly what is happening in this PR, let's Zoom on this.

src/plugins/kibana_utils/common/persistable_state/index.ts Outdated Show resolved Hide resolved
src/plugins/kibana_utils/common/persistable_state/index.ts Outdated Show resolved Hide resolved
@streamich
Copy link
Contributor

To fix type check error you could do something like this:

image

streamich
streamich approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked that Lens visualizations can migrate from 7.12 to latest.

ppisljar added 3 commits July 6, 2021 15:10
@ppisljar
fixing
4b74086
@ppisljar
Merge branch 'master' into persistable_stae
dcf0a19 
# Conflicts:
#	src/plugins/kibana_utils/common/persistable_state/index.ts
@ppisljar
Merge branch 'master' into persistable_stae
47ae051 
# Conflicts:
#	src/plugins/kibana_utils/common/persistable_state/index.ts
clintandrewhall
clintandrewhall approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@clintandrewhall clintandrewhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock from @elastic/kibana-presentation

src/plugins/dashboard/server/saved_objects/dashboard_migrations.ts Outdated Show resolved Hide resolved
@ppisljar
Copy link
Member Author

ppisljar commented Jul 7, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
embeddable 102 103 +1
kibanaUtils 236 237 +1
total +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
embeddable 383 384 +1
kibanaUtils 356 359 +3
total +4

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 181.6KB 182.3KB +765.0B
kibanaUtils 171.8KB 172.5KB +708.0B
total +1.4KB
Unknown metric groups

API count

id before after diff
embeddable 455 456 +1
kibanaUtils 549 551 +2
total +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ppisljar ppisljar merged commit 5aa8a0a into elastic:master Jul 7, 2021
@ppisljar ppisljar mentioned this pull request Jul 7, 2021
Merged
ppisljar added a commit to ppisljar/kibana that referenced this pull request Jul 7, 2021
@ppisljar
persistable state migrations (elastic#103680)
9b01cae
ppisljar added a commit that referenced this pull request Jul 7, 2021
@ppisljar
persistable state migrations (#103680) (#104764)
026a7b4
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 8, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into fleet/fix-use…
8a8729b 
…-of-max-results

* 'master' of github.com:elastic/kibana: (36 commits)
  Lower Kibana app bundle limits (elastic#104688)
  [Security Solutions] Fixes bug with the filter query compatibility for transforms (elastic#104559)
  [RAC] Add mapping update logic to RuleDataClient (elastic#102586)
  Fix import workpad (elastic#104722)
  [canvas] Fix Storybook service decorator (elastic#104750)
  [Detection Rules] Add 7.14 rules (elastic#104772)
  [Enterprise Search] Fix beta notification in sidebar (elastic#104763)
  Fix engine routes that are meta engine or non-meta-engine specific (elastic#104757)
  [Fleet] Fix policy revision number getting bumped for no reason (elastic#104696)
  persistable state migrations (elastic#103680)
  [Fleet] Fix add agent in the package policy table (elastic#104749)
  [DOCS] Creates separate doc for security in production (elastic#103973)
  [SO Migration] fix reindex race on multi-instance mode (elastic#104516)
  [Security Solution] Update text in Endpoint Admin pages (elastic#104649)
  [package testing] Decrease timeout to 2 hours (elastic#104668)
  Fix background styling of waterfall chart sidebar tooltip. (elastic#103997)
  [Fleet + Integrations UI] Integrations UI Cleanup (elastic#104641)
  [Fleet] Link to download page of current stack version on Agent install instructions (elastic#104494)
  [Workplace Search] Fix Media Type field preview is unformatted bug (elastic#104684)
  [ML] add marker body (elastic#104672)
  ...

# Conflicts:
#	x-pack/plugins/fleet/public/search_provider.test.ts
@ppisljar ppisljar mentioned this pull request Jul 8, 2021
Closed
3 tasks
@ThomThomson ThomThomson mentioned this pull request Apr 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamich streamich streamich approved these changes

@clintandrewhall clintandrewhall clintandrewhall approved these changes

Assignees
No one assigned
Labels
Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ppisljar @streamich @kibanamachine @clintandrewhall