Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY] Replaces hard-coded links with doc link service #103823

Merged
merged 7 commits into from
Aug 5, 2021

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jun 30, 2021

Summary

Related to #88107

This PR replaces hard-coded doc links in the Security app with calls to the doc link service, which is easier to maintain and tested as part of the documentation builds.

The necessary URLs were added to the doc link service in #102246 and #102676

Screenshots

For example:

image

@lcawl lcawl added the WIP Work in progress label Jun 30, 2021
@lcawl
Copy link
Contributor Author

lcawl commented Jun 30, 2021

@elasticmachine merge upstream

@lcawl lcawl added docs Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.15.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes and removed WIP Work in progress labels Jun 30, 2021
@lcawl lcawl marked this pull request as ready for review June 30, 2021 15:07
@lcawl lcawl requested a review from a team as a code owner June 30, 2021 15:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@lcawl lcawl requested a review from a team June 30, 2021 15:07
@lcawl
Copy link
Contributor Author

lcawl commented Jul 6, 2021

@elasticmachine merge upstream

@lcawl
Copy link
Contributor Author

lcawl commented Jul 12, 2021

@elasticmachine merge upstream

@lcawl
Copy link
Contributor Author

lcawl commented Aug 4, 2021

@elasticmachine merge upstream

@kibanamachine kibanamachine requested a review from a team as a code owner August 4, 2021 21:16
@jmikell821
Copy link
Contributor

@oatkiller can you review/approve this PR please?

@lcawl
Copy link
Contributor Author

lcawl commented Aug 5, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.5MB 6.5MB -463.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.14.1 v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants