Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet][Logs UI] Ensure the <LogStream /> component reacts to query changes #103876

Merged
merged 4 commits into from
Jul 7, 2021
Merged

[Fleet][Logs UI] Ensure the <LogStream /> component reacts to query changes #103876

merged 4 commits into from
Jul 7, 2021

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Jun 30, 2021 •
edited by jen-huang
Loading

Summary

On #102980 we detected a bug that triggered too many refreshes in the <LogStream/> component on cases where the query didn't change. It introduced a problem where changing the query didn't trigger a refresh at the right time.

This PR fixes that. Resolves #103563.

@afgomez afgomez added v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 30, 2021
@afgomez afgomez requested a review from a team as a code owner June 30, 2021 12:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Feature:Fleet)

@afgomez afgomez mentioned this pull request Jun 30, 2021
Closed
@afgomez afgomez enabled auto-merge (squash) June 30, 2021 16:01
@spalger spalger added v7.15.0 and removed v7.14.0 labels Jun 30, 2021
@afgomez
Copy link
Contributor Author

afgomez commented Jul 5, 2021

@elasticmachine merge upstream

@mgiota
Copy link
Contributor

mgiota commented Jul 6, 2021

@afgomez I have a question regarding version labels. Since it's already been code freeze, do we still need v7.14.0?

@jen-huang
Copy link
Contributor

@mgiota Yes, bug fixes can go in post-FF.

@afgomez
Copy link
Contributor Author

afgomez commented Jul 6, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.7MB 1.7MB +5.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @afgomez

@afgomez
Copy link
Contributor Author

afgomez commented Jul 6, 2021 •
edited
Loading

I have a question regarding version labels. Since it's already been code freeze, do we still need v7.14.0?

@mgiota What @jen-huang said :)

@mgiota
Copy link
Contributor

mgiota commented Jul 7, 2021

LGTM! I tested it and verify that logs view refreshes when searching for a query. It also refreshes when clicking on the dataset dropdown.

@afgomez afgomez merged commit f5c4a05 into elastic:master Jul 7, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 7, 2021
@kibanamachine
[Fleet][Logs UI] Ensure the <LogStream /> component reacts to query c…
aa66d1e 
…hanges (elastic#103876)

* Ensure the <LogStream /> component reacts to query changes

* Remove unused import
@kibanamachine kibanamachine mentioned this pull request Jul 7, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 7, 2021
@kibanamachine
[Fleet][Logs UI] Ensure the <LogStream /> component reacts to query c…
fbc6540 
…hanges (elastic#103876)

* Ensure the <LogStream /> component reacts to query changes

* Remove unused import
@kibanamachine kibanamachine mentioned this pull request Jul 7, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 7, 2021
@kibanamachine
[Fleet][Logs UI] Ensure the <LogStream /> component reacts to query c…
49bdffd 
…hanges (#103876) (#104597)

* Ensure the <LogStream /> component reacts to query changes

* Remove unused import

Co-authored-by: Alejandro Fernández Gómez <alejandro.fernandez@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 7, 2021
@kibanamachine
[Fleet][Logs UI] Ensure the <LogStream /> component reacts to query c…
bce1c6c 
…hanges (#103876) (#104598)

* Ensure the <LogStream /> component reacts to query changes

* Remove unused import

Co-authored-by: Alejandro Fernández Gómez <alejandro.fernandez@elastic.co>
darnautov pushed a commit to darnautov/kibana that referenced this pull request Jul 7, 2021
@darnautov
[Fleet][Logs UI] Ensure the <LogStream /> component reacts to query c…
689dbfe 
…hanges (elastic#103876)

* Ensure the <LogStream /> component reacts to query changes

* Remove unused import
@afgomez afgomez deleted the 103563-log-view-refresh branch July 8, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgiota mgiota mgiota approved these changes

@jen-huang jen-huang jen-huang approved these changes

Assignees

@afgomez afgomez

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Fleet Fleet team's agent central management project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] logs dataset / level selection in Agent Logs view is not auto-refreshing the view with each click
6 participants
@afgomez @elasticmachine @mgiota @jen-huang @kibanamachine @spalger