[APM] When using search bar UI should fall back to transactions

[cauemarcondes]

closes #103425

[elasticmachine]

Pinging @elastic/apm-ui (Team:apm)

[sorenlouv]

lgtm

[dgieselaar]

Have we thought about the difference between auto and always? If always is selected, should it still fall back to transaction documents? always was mostly intended as a way to prevent an extra ES call. But it might be reasonable to fall back to transaction documents if kuery is a (non-empty) string.

[sorenlouv]

Have we thought about the difference between auto and always? If always is selected, should it still fall back to transaction documents? always was mostly intended as a way to prevent an extra ES call. But it might be reasonable to fall back to transaction documents if kuery is a (non-empty) string.

If always falls back to using transactions, then what is the difference between always and auto? Right now it doesn't fallback and I think that makes sense.

[sorenlouv]

Oh.. I see what you mean now:

export async function getSearchAggregatedTransactions({
  config,
  start,
  end,
  kuery,
  apmEventClient,
}: {...}) {
  const searchAggregatedTransactions =
    config['xpack.apm.searchAggregatedTransactions'];

  if (
    kuery || searchAggregatedTransactions === SearchAggregatedTransactionSetting.auto
  ) {
    return getHasAggregatedTransactions({ start, end, kuery, apmEventClient });
  }

  return (
    searchAggregatedTransactions === SearchAggregatedTransactionSetting.always
  );
}

I think that makes sense

[cauemarcondes]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 84827af
• Storybooks Preview

Metrics [docs]

✅ unchanged

History

• 💔 Build #136343 failed f5e813c
• 💚 Build #135777 succeeded cb35e94

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kibanamachine]

💚 Backport successful

Status	Branch	Result
✅	7.14
✅	7.x

The backport PRs will be merged automatically after passing CI.