-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cases] Migrate connector ID to references #104221
Merged
jonathan-buttner
merged 28 commits into
elastic:master
from
jonathan-buttner:migrate-connector-id
Aug 4, 2021
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
e6dc819
Starting configure migration
jonathan-buttner a62c282
Merge branch 'master' of github.com:elastic/kibana into migrate-conne…
jonathan-buttner ab586b0
Initial refactor of configuration connector id
jonathan-buttner 6a0d9e2
Merge branch 'master' of github.com:elastic/kibana into migrate-conne…
jonathan-buttner d3be649
Merge branch 'master' of github.com:elastic/kibana into migrate-conne…
jonathan-buttner dbf84dd
Additional clean up and tests
jonathan-buttner adbb016
Merge branch 'master' of github.com:elastic/kibana into migrate-conne…
jonathan-buttner 6c00c6b
Adding some tests
jonathan-buttner 54cd2d2
Finishing configure tests
jonathan-buttner aed1b30
Starting case attributes transformation refactor
jonathan-buttner 636c586
adding more tests for the cases service
jonathan-buttner 37ef451
Adding more functionality and tests for cases migration
jonathan-buttner 48a449d
Finished unit tests for cases transition
jonathan-buttner 68137ea
Merge branch 'master' of github.com:elastic/kibana into migrate-conne…
jonathan-buttner 2029b4e
Finished tests and moved types
jonathan-buttner 3b530ba
Cleaning up type names
jonathan-buttner f653634
Fixing types and renaming
jonathan-buttner a1a01d2
Adding more tests directly for the transformations
jonathan-buttner 3affb65
Fixing tests and renaming some functions
jonathan-buttner b27d7b8
Merge branch 'master' of github.com:elastic/kibana into migrate-conne…
jonathan-buttner 3be7768
Adding transformation helper tests
jonathan-buttner d418f91
Adding migration utility tests and some clean up
jonathan-buttner 13d8ffd
Begining logic to remove references when it is the none connector
jonathan-buttner 17cb102
Fixing merge reference bug
jonathan-buttner 7689a83
Merge branch 'master' of github.com:elastic/kibana into migrate-conne…
jonathan-buttner 290ec82
Addressing feedback
jonathan-buttner 7f7a35b
Changing test name and creating constants file
jonathan-buttner eb94ffd
Merge branch 'master' of github.com:elastic/kibana into migrate-conne…
jonathan-buttner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixing merge reference bug
- Loading branch information
commit 17cb10222bfff382edf58ddc502c262ead8be94e
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block now zips togethers the original case if it existed and the updated request. This is particularly useful for when we call the
patch
request so that we can populate theoriginalCase
field. If the original case cannot be found within the map we skip the request. This shouldn't even happen though because the code above should handle finding requests that don't exist.