Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Adding tests for ML's field caps endpoint #104315

Merged
merged 2 commits into from
Jul 7, 2021
Merged

[ML] Adding tests for ML's field caps endpoint #104315

merged 2 commits into from
Jul 7, 2021

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Jul 5, 2021 •
edited
Loading

Adds tests for the field_caps endpoint.
This endpoint is a basic wrapper around the es endpoint, with some logic to manage the field selection passed to it.
These tests just focus on this field selection, they do not focus on testing es's field_caps endpoint.

Relates to #97982

@jgowdyelastic jgowdyelastic requested a review from a team as a code owner July 5, 2021 15:00
@jgowdyelastic jgowdyelastic self-assigned this Jul 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic added auto-backport Deprecated - use backport:version if exact versions are needed non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0 labels Jul 5, 2021
jgowdyelastic
jgowdyelastic commented Jul 5, 2021
View reviewed changes
x-pack/test/api_integration/apis/ml/index.ts
@@ -68,17 +68,18 @@ export default function ({ getService, loadTestFile }: FtrProviderContext) {
await ml.testResources.resetKibanaTimeZone();
});

loadTestFile(require.resolve('./modules'));
loadTestFile(require.resolve('./annotations'));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ordering these alphabetically

This was referenced Jul 5, 2021
Closed
Closed
peteharverson
peteharverson approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

darnautov
darnautov approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit 85f831b into elastic:master Jul 7, 2021
@jgowdyelastic jgowdyelastic deleted the adding-ml-field-caps-tests branch July 7, 2021 08:01
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 7, 2021
@jgowdyelastic @kibanamachine
[ML] Adding tests for ML's field caps endpoint (elastic#104315)
3de9e73 
* [ML] Adding tests for ML's field caps endpoint

* fixing typos
@kibanamachine kibanamachine mentioned this pull request Jul 7, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 7, 2021
@jgowdyelastic @kibanamachine
[ML] Adding tests for ML's field caps endpoint (elastic#104315)
f49f2bd 
* [ML] Adding tests for ML's field caps endpoint

* fixing typos
@kibanamachine kibanamachine mentioned this pull request Jul 7, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 7, 2021
@kibanamachine @jgowdyelastic
[ML] Adding tests for ML's field caps endpoint (#104315) (#104588)
724788d 
* [ML] Adding tests for ML's field caps endpoint

* fixing typos

Co-authored-by: James Gowdy <jgowdy@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 7, 2021
@kibanamachine @jgowdyelastic
[ML] Adding tests for ML's field caps endpoint (#104315) (#104587)
9979eb9 
* [ML] Adding tests for ML's field caps endpoint

* fixing typos

Co-authored-by: James Gowdy <jgowdy@elastic.co>
darnautov pushed a commit to darnautov/kibana that referenced this pull request Jul 7, 2021
@jgowdyelastic @darnautov
[ML] Adding tests for ML's field caps endpoint (elastic#104315)
9f777cd 
* [ML] Adding tests for ML's field caps endpoint

* fixing typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@darnautov darnautov darnautov approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
auto-backport Deprecated - use backport:version if exact versions are needed :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgowdyelastic @elasticmachine @kibanamachine @darnautov @peteharverson