Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix long data for investigation not truncate on the rule details page #104428

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Fix long data for investigation not truncate on the rule details page #104428

merged 1 commit into from
Jul 6, 2021

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Jul 6, 2021 •
edited
Loading

issue comment: #99884 (comment)

Summary

Add word-break: break-word to force lines to break on long words.

Before

Screenshot 2021-07-06 at 14 29 56

after

Screenshot 2021-07-06 at 14 29 45

@machadoum machadoum requested a review from a team as a code owner July 6, 2021 12:33
@machadoum machadoum self-assigned this Jul 6, 2021
@machadoum machadoum added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team labels Jul 6, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@machadoum machadoum mentioned this pull request Jul 6, 2021
Closed
@machadoum machadoum requested a review from cnasikas July 6, 2021 12:37
@machadoum machadoum added the bug Fixes for quality problems that affect the customer experience label Jul 6, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.3MB 6.3MB +22.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

cnasikas
cnasikas approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally! LGTM!

@cnasikas cnasikas merged commit 52c7824 into elastic:master Jul 6, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 6, 2021
@machadoum @kibanamachine
Fix long data for investigation not truncate on the rule details page (…
6d84160 
…elastic#104428)

Author: Pablo Machado <machadoum@gmail.com>
Co-authored-by: Pablo Machado <machadoum@gmail.com>
@kibanamachine kibanamachine mentioned this pull request Jul 6, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 6, 2021
@kibanamachine @machadoum
Fix long data for investigation not truncate on the rule details page (…
3120873 
…#104428) (#104551)

Author: Pablo Machado <machadoum@gmail.com>
Co-authored-by: Pablo Machado <machadoum@gmail.com>

Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
Co-authored-by: Pablo Machado <machadoum@gmail.com>
@cnasikas cnasikas mentioned this pull request Jul 7, 2021
Merged
cnasikas added a commit that referenced this pull request Jul 7, 2021
@cnasikas @machadoum
Fix long data for investigation not truncate on the rule details page (…
d417b7a 
…#104428) (#104601)

Author: Pablo Machado <machadoum@gmail.com>
Co-authored-by: Pablo Machado <machadoum@gmail.com>

Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
Co-authored-by: Pablo Machado <machadoum@gmail.com>
darnautov pushed a commit to darnautov/kibana that referenced this pull request Jul 7, 2021
@machadoum @darnautov
Fix long data for investigation not truncate on the rule details page (…
8916673 
…elastic#104428)

Author: Pablo Machado <machadoum@gmail.com>
Co-authored-by: Pablo Machado <machadoum@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnasikas cnasikas cnasikas approved these changes

Assignees

@machadoum machadoum

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@machadoum @elasticmachine @kibanamachine @cnasikas