Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Table view - fix the display of table elements if they are in the URL form #105051

Merged
merged 1 commit into from
Jul 9, 2021
Merged

[TSVB] Table view - fix the display of table elements if they are in the URL form #105051

merged 1 commit into from
Jul 9, 2021

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jul 9, 2021 •
edited
Loading

Summary

[TSVB] Table view - fix the display of table elements if they are in the URL form

Steps to reproduce

  1. Create or open TSVB visualization
  2. Go to Table view and configure some aggregation
  3. Set some value for Item URL
    image

Expected result:

URLs should be accessible, clickable, and have a right visible name.

image

Actual result: (PR fix that)

image

@alexwizp alexwizp changed the title [TSVB] Table view - fix display of item urls [TSVB] Table view - fix the display of table elements if they are in the URL form Jul 9, 2021
@alexwizp alexwizp self-assigned this Jul 9, 2021
@alexwizp alexwizp added v7.14.0 v7.15.0 v8.0.0 release_note:fix Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 9, 2021
@alexwizp alexwizp marked this pull request as ready for review July 9, 2021 12:55
@alexwizp alexwizp requested a review from a team July 9, 2021 12:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

stratoula
stratoula approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clde LGTM, tested it locally on Chrome. Thanx for the test :D

@alexwizp alexwizp enabled auto-merge (squash) July 9, 2021 13:20
@alexwizp alexwizp added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 9, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 1007.3KB 1007.4KB +32.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@alexwizp alexwizp merged commit 4806cf3 into elastic:master Jul 9, 2021
@kibanamachine kibanamachine mentioned this pull request Jul 9, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 9, 2021
@alexwizp @kibanamachine
[TSVB] Table view - fix display of item urls (elastic#105051)
b2734bc
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 9, 2021
@alexwizp @kibanamachine
[TSVB] Table view - fix display of item urls (elastic#105051)
d67cc08
@kibanamachine kibanamachine mentioned this pull request Jul 9, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 9, 2021
@kibanamachine @alexwizp
[TSVB] Table view - fix display of item urls (#105051) (#105064)
90a1fb4 
Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
kibanamachine added a commit that referenced this pull request Jul 9, 2021
@kibanamachine @alexwizp
[TSVB] Table view - fix display of item urls (#105051) (#105063)
861eafa 
Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DianaDerevyankina DianaDerevyankina DianaDerevyankina approved these changes

@stratoula stratoula stratoula approved these changes

@VladLasitsa VladLasitsa Awaiting requested review from VladLasitsa

Assignees

@alexwizp alexwizp

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexwizp @elasticmachine @kibanamachine @stratoula @DianaDerevyankina