Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes "servers.elasticsearch.auth" must be a string error #105095

Merged

Conversation

MadameSheema
Copy link
Member

Summary

Fixes "servers.elasticsearch.auth" must be a string error when running the upgrade config using the functional_test_runner script.

At the upgrade config, we were loading the general configuration as well causing the above error. For the upgrade testing we don't need that general configuration that referentiates to the ELS and KBN instances since we are passing those values from the stack testing repo.

@MadameSheema MadameSheema added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.14.0 labels Jul 9, 2021
@MadameSheema MadameSheema requested a review from liza-mae July 9, 2021 16:50
@MadameSheema MadameSheema self-assigned this Jul 9, 2021
@MadameSheema MadameSheema requested a review from a team as a code owner July 9, 2021 16:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema
Copy link
Member Author

@elasticmachine merge upstream

@liza-mae
Copy link
Contributor

I am still unable to get these tests to run on cloud with these changes, steps to reproduce found here: https://github.com/elastic/elastic-stack-testing/pull/934#issuecomment-877272865

It failed first with this path /internal/security/login, which throws Status: 401 - Unauthorized does so manually as well.
I changed the path to /security/login, but that throws another error Status: 404 - Not Found although manually the link is correct.

Don't know how to debug these tests, first time I run them, but seems like there is still something missing.

@liza-mae
Copy link
Contributor

liza-mae commented Jul 12, 2021

Paired with @MadameSheema we resolved first issue unauthorized.
Fix should be line 218 basic not cloud-basic

Now the error

Timed out retrying after 4000ms: expected '<a.euiLink.euiLink--primary>' to have text 'Custom query rule for upgrade', but the text was 'Rule Name'
cypress/upgrade_integration/custom_query_rule.spec.ts:27:23
 25 |     goToManageAlertsDetectionRules();
  26 |     waitForRulesTableToBeLoaded();
> 27 |     cy.get(RULE_NAME).should('have.text', 'Custom query rule for upgrade');
     |                       ^
  28 |   });
  29 | });
  30 |

BTW that error was caught via visual not headless - in headless it does not error it appears to hang, not sure why.

@liza-mae
Copy link
Contributor

The fixes we found:

  • The rule name was mismatched to the setup in ESTF repo and Kibana repo
  • Provider name cloud-basic is used on cloud production but basic is used on staging, we discussed making it handle both.

@MadameSheema
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Contributor

@liza-mae liza-mae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tests pass now on staging

@MadameSheema
Copy link
Member Author

@elasticmachine merge upstream

@MadameSheema
Copy link
Member Author

@elasticmachine merge upstream

@MadameSheema
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

@MadameSheema MadameSheema merged commit 9f2d9d4 into elastic:master Jul 16, 2021
@MadameSheema MadameSheema deleted the fixes-stack-testing-integration branch July 16, 2021 14:19
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Jul 16, 2021
…5095)

* fixes integration with stack testing upgrade framework

* fixes the provider name flexibility

* fixes type check error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Jul 16, 2021
…5095)

* fixes integration with stack testing upgrade framework

* fixes the provider name flexibility

* fixes type check error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
MadameSheema added a commit that referenced this pull request Jul 16, 2021
…105961)

* fixes integration with stack testing upgrade framework

* fixes the provider name flexibility

* fixes type check error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
MadameSheema added a commit that referenced this pull request Jul 16, 2021
…105960)

* fixes integration with stack testing upgrade framework

* fixes the provider name flexibility

* fixes type check error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants