[Dashboard] Adds migration smoke tests for TSVB panels on dashboard #105655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crob611
added
review
Feature:Dashboard
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
@stratoula Would also love any feedback if you think of any other cases that might should be covered. |
4 tasks
|
@crob611 it looks awesome! My only feedback is that maybe we should test a 7.13.3 TSVB viz which uses index pattern. |
ThomThomson
approved these changes
Jul 21, 2021
There was a problem hiding this comment.
Code only review, so I haven't seen the TSVB charts used in these smoke tests - but from what I've heard, you and the Kibana app team were able to create a representative sample.
It will be good to get all of these tests into master, so that we can clean them up all at once after the testing harness is merged, as part of #106290. This PR duplicates coverage of dashboards from 7.13.1, and 7.12.1, so ideally we can write a generic system which loads all of these dashboards at once via kbn_archiver, then loops through them and runs the same smoke tests. At that point, testing migrations from a new version -> latest will be as easy as appending a new kbn_archiver export to the end of the file.
|
@elasticmachine merge upstream |
crob611
added
the
auto-backport
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Public APIs missing comments
Any counts in public APIs
Public APIs missing exports
Unknown metric groupsAPI count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 26, 2021
…lastic#105655) * Adds migration smoke tests for TSVB panels on dashboard * Adds index pattern TSVB panel * Update 7.13.3 export Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
…lastic#105655) * Adds migration smoke tests for TSVB panels on dashboard * Adds index pattern TSVB panel * Update 7.13.3 export Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds some smoke tests for migration of TSVB By Value panels on a Dashboard.
There are two exported dashboards that get tested by being imported through Saved Object import and confirming the import was successful, and by visiting the dashboard and confirming there are no error panels.
One is created using 7.12.1. It has panels for Time Series, Metric, Top N, Gauge, Markdown, Table, and a Time Series w/ Annotations. It also includes some drilldowns on some panels and tests that those drill downs are also properly migrated.
The second is created using 7.13.3. It has a Time Series panel that is not using a Kibana Index Pattern.