[5.x] Warn if the title is a duplicate #10566
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backports PR #10321 **Commit 1:** Warn if the title is a duplicate * Original sha: b0aa0b8 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-02-13T18:07:23Z **Commit 2:** warn when copyOnSave is checked. add a test * Original sha: ee42002 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-02-14T14:20:37Z **Commit 3:** update message * Original sha: c90c8ae * Authored by Stacey Gammon <gammon@elastic.co> on 2017-02-14T14:24:50Z **Commit 4:** fix tests * Original sha: 5ec1a92 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-02-14T15:04:14Z **Commit 5:** Fix issues with substring matching add more tests. * Original sha: 4335e9e * Authored by Stacey Gammon <gammon@elastic.co> on 2017-02-14T18:54:58Z **Commit 6:** make case insensitive and return matching title * Original sha: 8881739 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-02-14T19:34:04Z **Commit 7:** Fix bug caused by subtle difference between this.type and type Add a comment and rename one of the variables to make the distinction clearer. * Original sha: f4011ce * Authored by Stacey Gammon <gammon@elastic.co> on 2017-02-16T16:31:13Z **Commit 8:** add debug messages. * Original sha: 2d44889 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-02-16T18:05:03Z **Commit 9:** fix tests again * Original sha: 3212c91 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-02-16T22:10:25Z **Commit 10:** uncomment out tests * Original sha: 1f2cb28 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-02-16T22:12:06Z **Commit 11:** more debug messages * Original sha: 807b190 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-02-17T02:09:37Z **Commit 12:** save more screenshots * Original sha: 3d025e9 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-02-17T02:34:29Z **Commit 13:** Need to wait till save finishes or the page may redirect the url after the page has navigated away * Original sha: de00e24 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-02-17T14:01:22Z **Commit 14:** address code review comments * Original sha: 7bc0268 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-02-17T17:28:34Z
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn if the title is a duplicate
Backports PR #10321
Commit 1:
Warn if the title is a duplicate
Commit 2:
warn when copyOnSave is checked. add a test
Commit 3:
update message
Commit 4:
fix tests
Commit 5:
Fix issues with substring matching
add more tests.
Commit 6:
make case insensitive and return matching title
Commit 7:
Fix bug caused by subtle difference between this.type and type
Add a comment and rename one of the variables to make the distinction
clearer.
Commit 8:
add debug messages.
Commit 9:
fix tests again
Commit 10:
uncomment out tests
Commit 11:
more debug messages
Commit 12:
save more screenshots
Commit 13:
Need to wait till save finishes or the page may redirect the url after the page has navigated away
Commit 14:
address code review comments