Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Fleet] Improve OpenAPI accuracy and validity (#105679) #105781

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

* Improve schema from object to $ref

* Add description and response schema for /agent-status endpoint

* Remove code related to removed /install/:os endpoint

* Add response schemas for enrollment-api-key operations

* Add response schemas for /agents/:agentId

* Fix two security scheme names

* Change format for reference selectors

* Replace Ingest Manager with Fleet in OpenAPI spec

* Replace instances of Ingest Manager with Fleet

* Update instructions to create bundled specs
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 516 515 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1037 1035 -2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 448.3KB 447.9KB -387.0B
Unknown metric groups

API count

id before after diff
fleet 1132 1130 -2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jfsiii

@kibanamachine kibanamachine merged commit 9ce1b84 into elastic:7.x Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants